From 267756fc9390113bd62d6fcd8318283344d556fe Mon Sep 17 00:00:00 2001
From: ryan <ryan@1a063a9b-81f0-0310-95a4-ce76da25c4cd>
Date: Sat, 1 Mar 2008 20:41:18 +0000
Subject: [PATCH] Fix passed by reference errors. Props DD32. fixes #6056

git-svn-id: http://svn.automattic.com/wordpress/trunk@7124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
---
 wp-admin/includes/media.php | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/wp-admin/includes/media.php b/wp-admin/includes/media.php
index 0ae5dad696..ac9f9a7a9a 100644
--- a/wp-admin/includes/media.php
+++ b/wp-admin/includes/media.php
@@ -32,8 +32,10 @@ function the_media_upload_tabs() {
 		echo "<ul id='sidemenu'>\n";
 		if ( isset($_GET['tab']) && array_key_exists($_GET['tab'], $tabs) )
 			$current = $_GET['tab'];
-		else
-			$current = array_shift(array_keys($tabs));
+		else {
+			$keys = array_keys($tabs);
+			$current = array_shift($keys);
+		}
 		foreach ( $tabs as $callback => $text ) {
 			$class = '';
 			if ( $current == $callback )
@@ -239,7 +241,8 @@ function media_upload_form_handler() {
 		return media_send_to_editor('[gallery]');
 
 	if ( isset($_POST['send']) ) {
-		$send_id = (int) array_shift(array_keys($_POST['send']));
+		$keys = array_keys($_POST['send']);
+		$send_id = (int) array_shift($keys);
 		$attachment = $_POST['attachments'][$send_id];
 		$html = apply_filters('media_send_to_editor', get_the_attachment_link($send_id, 0, array(125,125), !empty($attachment['post_content'])), $send_id, $attachment);
 		return media_send_to_editor($html);
@@ -629,7 +632,8 @@ function get_media_item( $attachment_id, $errors = null, $send = true, $delete =
 	}
 
 	if ( isset($post_mime_types) ) {
-		$type = array_shift(array_keys(wp_match_mime_types(array_keys($post_mime_types), $post->post_mime_type)));
+		$keys = array_keys(wp_match_mime_types(array_keys($post_mime_types), $post->post_mime_type));
+		$type = array_shift($keys);
 		$type = "<input type='hidden' id='type-of-$attachment_id' value='$type' />";
 	}