From 3eafdad2992800fca4a6930df9516ee4117db891 Mon Sep 17 00:00:00 2001 From: Gary Pendergast Date: Fri, 14 Dec 2018 05:55:53 +0000 Subject: [PATCH] Meta Boxes: Fix error when a meta box is rendered with a static method callback. When `WP_DEBUG` is set, ensure that a static method callback is passed to `ReflectionMethod`, instead of `ReflectionFunction`. Merges [43830] from the 5.0 branch to trunk. Props DrewAPicture. Fixes #45192. Built from https://develop.svn.wordpress.org/trunk@44170 git-svn-id: http://core.svn.wordpress.org/trunk@44000 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-admin/includes/template.php | 2 ++ wp-includes/version.php | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/wp-admin/includes/template.php b/wp-admin/includes/template.php index a1cd160076..58505fa9f4 100644 --- a/wp-admin/includes/template.php +++ b/wp-admin/includes/template.php @@ -1187,6 +1187,8 @@ function do_meta_boxes( $screen, $context, $object ) { if ( WP_DEBUG && ! $screen->is_block_editor() && ! isset( $_GET['meta-box-loader'] ) ) { if ( is_array( $box['callback'] ) ) { $reflection = new ReflectionMethod( $box['callback'][0], $box['callback'][1] ); + } elseif ( false !== strpos( $box['callback'], '::' ) ) { + $reflection = new ReflectionMethod( $box['callback'] ); } else { $reflection = new ReflectionFunction( $box['callback'] ); } diff --git a/wp-includes/version.php b/wp-includes/version.php index a68d0c917e..025e46c749 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -13,7 +13,7 @@ * * @global string $wp_version */ -$wp_version = '5.1-alpha-44169'; +$wp_version = '5.1-alpha-44170'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.