Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`. This commit also includes: * Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls. * Replacing `include` statements for several files with `require_once`, for consistency: * `wp-admin/admin-header.php` * `wp-admin/admin-footer.php` * `wp-includes/version.php` Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb. Fixes #48082. Built from https://develop.svn.wordpress.org/trunk@47198 git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
@@ -16,7 +16,7 @@
|
||||
*/
|
||||
|
||||
/** WordPress Administration Bootstrap */
|
||||
require_once( dirname( __FILE__ ) . '/admin.php' );
|
||||
require_once __DIR__ . '/admin.php';
|
||||
|
||||
$title = __( 'Settings' );
|
||||
$this_file = 'options.php';
|
||||
@@ -249,7 +249,7 @@ if ( 'update' == $action ) { // We are saving settings sent from a settings page
|
||||
|
||||
// Handle translation installation.
|
||||
if ( ! empty( $_POST['WPLANG'] ) && current_user_can( 'install_languages' ) ) {
|
||||
require_once( ABSPATH . 'wp-admin/includes/translation-install.php' );
|
||||
require_once ABSPATH . 'wp-admin/includes/translation-install.php';
|
||||
|
||||
if ( wp_can_install_language_pack() ) {
|
||||
$language = wp_download_language_pack( $_POST['WPLANG'] );
|
||||
@@ -316,7 +316,7 @@ if ( 'update' == $action ) { // We are saving settings sent from a settings page
|
||||
exit;
|
||||
}
|
||||
|
||||
include( ABSPATH . 'wp-admin/admin-header.php' ); ?>
|
||||
require_once ABSPATH . 'wp-admin/admin-header.php'; ?>
|
||||
|
||||
<div class="wrap">
|
||||
<h1><?php esc_html_e( 'All Settings' ); ?></h1>
|
||||
@@ -376,4 +376,4 @@ foreach ( (array) $options as $option ) :
|
||||
</div>
|
||||
|
||||
<?php
|
||||
include( ABSPATH . 'wp-admin/admin-footer.php' );
|
||||
require_once ABSPATH . 'wp-admin/admin-footer.php';
|
||||
|
||||
Reference in New Issue
Block a user