From 6335e08ab25cf892d7e40898971d3edf0ee12e15 Mon Sep 17 00:00:00 2001 From: Konstantin Obenland Date: Mon, 3 Oct 2016 18:13:31 +0000 Subject: [PATCH] Themes: Account for uppercase chars when managing themes. Fixes a bug where the UI wasn't updated after deleting/updating a theme. Also introduces unit tests for theme management ajax handlers. For now they're focused on `wp_ajax_update_theme()` but they can include tests for other handlers as well. Props chrisjean for initial patch. Fixes #37924. Built from https://develop.svn.wordpress.org/trunk@38710 git-svn-id: http://core.svn.wordpress.org/trunk@38653 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-admin/includes/ajax-actions.php | 4 ++-- wp-includes/version.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/wp-admin/includes/ajax-actions.php b/wp-admin/includes/ajax-actions.php index e3016258cd..cc9fa432fc 100644 --- a/wp-admin/includes/ajax-actions.php +++ b/wp-admin/includes/ajax-actions.php @@ -3405,7 +3405,7 @@ function wp_ajax_update_theme() { ) ); } - $stylesheet = sanitize_key( wp_unslash( $_POST['slug'] ) ); + $stylesheet = preg_replace( '/[^A-z0-9_\-]/', '', wp_unslash( $_POST['slug'] ) ); $status = array( 'update' => 'theme', 'slug' => $stylesheet, @@ -3490,7 +3490,7 @@ function wp_ajax_delete_theme() { ) ); } - $stylesheet = sanitize_key( wp_unslash( $_POST['slug'] ) ); + $stylesheet = preg_replace( '/[^A-z0-9_\-]/', '', wp_unslash( $_POST['slug'] ) ); $status = array( 'delete' => 'theme', 'slug' => $stylesheet, diff --git a/wp-includes/version.php b/wp-includes/version.php index 3899d13b45..5a80fd876a 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -4,7 +4,7 @@ * * @global string $wp_version */ -$wp_version = '4.7-alpha-38709'; +$wp_version = '4.7-alpha-38710'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.