HostForge-Systems/wordpress
Template
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Media: Add 'muted' attribute and normalize HTML attributes.

Browse Source 
Add the 'muted' attribute to the audio shortcode. Fix boolean attributes to meet HTML5 standards. Replaces instances like `attr="1"` with `attr` for `loop`, `autoplay`, and `muted`, and improves handling of the `preload` attribute to only output valid values.

Props shub07, dmsnell, debarghyabanerjee, audrasjb, narenin, apermo, joedolson.
Fixes #61515.
Built from https://develop.svn.wordpress.org/trunk@59987


git-svn-id: http://core.svn.wordpress.org/trunk@59329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
joedolson
2025-03-16 18:51:29 +00:00
parent abaebb17e6
commit c2b92db37c
2 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
wp-includes/media.php
View File

@@ -3345,6 +3345,7 @@ function wp_get_attachment_id3_keys( $attachment, $context = 'display' ) {
* WordPress mp3s in a post. * WordPress mp3s in a post.
* *
* @since 3.6.0 * @since 3.6.0
* @since 6.8.0 Added the 'muted' attribute.
* *
* @param array $attr { * @param array $attr {
* Attributes of the audio shortcode. * Attributes of the audio shortcode.
@@ -3352,6 +3353,7 @@ function wp_get_attachment_id3_keys( $attachment, $context = 'display' ) {
* @type string $src URL to the source of the audio file. Default empty. * @type string $src URL to the source of the audio file. Default empty.
* @type string $loop The 'loop' attribute for the `<audio>` element. Default empty. * @type string $loop The 'loop' attribute for the `<audio>` element. Default empty.
* @type string $autoplay The 'autoplay' attribute for the `<audio>` element. Default empty. * @type string $autoplay The 'autoplay' attribute for the `<audio>` element. Default empty.
* @type string $muted The 'muted' attribute for the `<audio>` element. Default 'false'.
* @type string $preload The 'preload' attribute for the `<audio>` element. Default 'none'. * @type string $preload The 'preload' attribute for the `<audio>` element. Default 'none'.
* @type string $class The 'class' attribute for the `<audio>` element. Default 'wp-audio-shortcode'. * @type string $class The 'class' attribute for the `<audio>` element. Default 'wp-audio-shortcode'.
* @type string $style The 'style' attribute for the `<audio>` element. Default 'width: 100%;'. * @type string $style The 'style' attribute for the `<audio>` element. Default 'width: 100%;'.
@@ -3390,6 +3392,7 @@ function wp_audio_shortcode( $attr, $content = '' ) {
'src' => '', 'src' => '',
'loop' => '', 'loop' => '',
'autoplay' => '', 'autoplay' => '',
'muted' => 'false',
'preload' => 'none', 'preload' => 'none',
'class' => 'wp-audio-shortcode', 'class' => 'wp-audio-shortcode',
'style' => 'width: 100%;', 'style' => 'width: 100%;',
@@ -3469,12 +3472,13 @@ function wp_audio_shortcode( $attr, $content = '' ) {
'id' => sprintf( 'audio-%d-%d', $post_id, $instance ), 'id' => sprintf( 'audio-%d-%d', $post_id, $instance ),
'loop' => wp_validate_boolean( $atts['loop'] ), 'loop' => wp_validate_boolean( $atts['loop'] ),
'autoplay' => wp_validate_boolean( $atts['autoplay'] ), 'autoplay' => wp_validate_boolean( $atts['autoplay'] ),
'muted' => wp_validate_boolean( $atts['muted'] ),
'preload' => $atts['preload'], 'preload' => $atts['preload'],
'style' => $atts['style'], 'style' => $atts['style'],
); );
// These ones should just be omitted altogether if they are blank. // These ones should just be omitted altogether if they are blank.
foreach ( array( 'loop', 'autoplay', 'preload' ) as $a ) { foreach ( array( 'loop', 'autoplay', 'preload', 'muted' ) as $a ) {
if ( empty( $html_atts[ $a ] ) ) { if ( empty( $html_atts[ $a ] ) ) {
unset( $html_atts[ $a ] ); unset( $html_atts[ $a ] );
} }
@@ -3482,8 +3486,20 @@ function wp_audio_shortcode( $attr, $content = '' ) {
$attr_strings = array(); $attr_strings = array();
foreach ( $html_atts as $k => $v ) { foreach ( $html_atts as $attribute_name => $attribute_value ) {
$attr_strings[] = $k . '="' . esc_attr( $v ) . '"'; if ( in_array( $attribute_name, array( 'loop', 'autoplay', 'muted' ), true ) && true === $attribute_value ) {
// Add boolean attributes without a value.
$attr_strings[] = esc_attr( $attribute_name );
} elseif ( 'preload' === $attribute_name && ! empty( $attribute_value ) ) {
// Handle the preload attribute with specific allowed values.
$allowed_preload_values = array( 'none', 'metadata', 'auto' );
if ( in_array( $attribute_value, $allowed_preload_values, true ) ) {
$attr_strings[] = sprintf( '%s="%s"', esc_attr( $attribute_name ), esc_attr( $attribute_value ) );
}
} else {
// For other attributes, include the value.
$attr_strings[] = sprintf( '%s="%s"', esc_attr( $attribute_name ), esc_attr( $attribute_value ) );
}
} }
$html = ''; $html = '';

2
wp-includes/version.php
View File

@@ -16,7 +16,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '6.8-beta2-59986'; $wp_version = '6.8-beta2-59987';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.