From ede8eb333af54b1d7b691fbebec75d17d310ac0f Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Wed, 24 Aug 2022 13:11:13 +0000 Subject: [PATCH] Code Modernization: Remove dynamic properties in `WP_Test_REST_Posts_Controller`. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0. In this particular case, the `test_create_update_post_with_featured_media()` method creates an attachment and writes the ID of the attachment to a dynamic (undeclared) property to be used as a flag to determine whether attachments need to be cleaned up after the test in the `tear_down()` method. As the actual ''value'' of the property is irrelevant for the cleaning up and the property is realistically being used as a “flag”, this is now fixed as follows: * Have an actual “flag” property declared with a descriptive name — `$attachments_created` — to make the code in the `tear_down()` more easily understandable. * As for the actual ID of the attachment, save that to a test method local variable as that is the only place where it has any relevance. Includes moving the `tear_down()` method up to be directly below the `set_up()` method. Follow-up to [38832], [53557], [53558], [53850], [53851], [53852], [53853], [53854], [53856], [53916]. Props jrf. See #56033. Built from https://develop.svn.wordpress.org/trunk@53935 git-svn-id: http://core.svn.wordpress.org/trunk@53494 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/version.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wp-includes/version.php b/wp-includes/version.php index 15850cea6c..c84072e9a5 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -16,7 +16,7 @@ * * @global string $wp_version */ -$wp_version = '6.1-alpha-53934'; +$wp_version = '6.1-alpha-53935'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.