From f1df157fa70bcfb6008fa40e45005ff75970a23f Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Fri, 23 Dec 2022 11:38:15 +0000 Subject: [PATCH] Code Modernization: Rename parameters that use reserved keywords in `wp-includes/theme.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$default` parameter to `$default_value` in `get_theme_mod()`. * Renames the `$include` parameter to `$file` in `require_if_theme_supports()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #56788. Built from https://develop.svn.wordpress.org/trunk@55014 git-svn-id: http://core.svn.wordpress.org/trunk@54547 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/theme.php | 24 ++++++++++++------------ wp-includes/version.php | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/wp-includes/theme.php b/wp-includes/theme.php index 47fe9cb162..c3a4206530 100644 --- a/wp-includes/theme.php +++ b/wp-includes/theme.php @@ -991,18 +991,18 @@ function get_theme_mods() { /** * Retrieves theme modification value for the active theme. * - * If the modification name does not exist and `$default` is a string, then the + * If the modification name does not exist and `$default_value` is a string, then the * default will be passed through the {@link https://www.php.net/sprintf sprintf()} * PHP function with the template directory URI as the first value and the * stylesheet directory URI as the second value. * * @since 2.1.0 * - * @param string $name Theme modification name. - * @param mixed $default Optional. Theme modification default value. Default false. + * @param string $name Theme modification name. + * @param mixed $default_value Optional. Theme modification default value. Default false. * @return mixed Theme modification value. */ -function get_theme_mod( $name, $default = false ) { +function get_theme_mod( $name, $default_value = false ) { $mods = get_theme_mods(); if ( isset( $mods[ $name ] ) ) { @@ -1020,17 +1020,17 @@ function get_theme_mod( $name, $default = false ) { return apply_filters( "theme_mod_{$name}", $mods[ $name ] ); } - if ( is_string( $default ) ) { + if ( is_string( $default_value ) ) { // Only run the replacement if an sprintf() string format pattern was found. - if ( preg_match( '#(?