From f6cb67e74654245a5c31befdf75153809847e29c Mon Sep 17 00:00:00 2001 From: Weston Ruter Date: Fri, 9 Jan 2026 02:48:51 +0000 Subject: [PATCH] Code Modernization: Upgrade/Install: Use null coalescing operator instead of `isset()` ternaries. Developed as a subset of https://github.com/WordPress/wordpress-develop/pull/10654 Initially developed in https://github.com/WordPress/wordpress-develop/pull/4886 Follow-up to [61454], [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61455 git-svn-id: http://core.svn.wordpress.org/trunk@60767 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-admin/includes/class-core-upgrader.php | 2 +- .../includes/class-language-pack-upgrader.php | 2 +- .../includes/class-plugin-installer-skin.php | 6 +-- wp-admin/includes/class-plugin-upgrader.php | 12 +++--- .../includes/class-theme-installer-skin.php | 6 +-- wp-admin/includes/class-theme-upgrader.php | 8 ++-- wp-admin/includes/update-core.php | 2 +- wp-admin/includes/update.php | 8 ++-- wp-admin/update-core.php | 20 ++++----- wp-admin/update.php | 2 +- wp-includes/css/dist/index.php | 42 +++++++++---------- wp-includes/js/dist/script-modules/index.php | 40 +++++++++--------- wp-includes/update.php | 6 +-- wp-includes/version.php | 2 +- 14 files changed, 79 insertions(+), 79 deletions(-) diff --git a/wp-admin/includes/class-core-upgrader.php b/wp-admin/includes/class-core-upgrader.php index 5cb818cd59..1843766542 100644 --- a/wp-admin/includes/class-core-upgrader.php +++ b/wp-admin/includes/class-core-upgrader.php @@ -403,7 +403,7 @@ class Core_Upgrader extends WP_Upgrader { public function check_files() { global $wp_version, $wp_local_package; - $checksums = get_core_checksums( $wp_version, isset( $wp_local_package ) ? $wp_local_package : 'en_US' ); + $checksums = get_core_checksums( $wp_version, $wp_local_package ?? 'en_US' ); if ( ! is_array( $checksums ) ) { return false; diff --git a/wp-admin/includes/class-language-pack-upgrader.php b/wp-admin/includes/class-language-pack-upgrader.php index 89b9f9ac87..733b109183 100644 --- a/wp-admin/includes/class-language-pack-upgrader.php +++ b/wp-admin/includes/class-language-pack-upgrader.php @@ -265,7 +265,7 @@ class Language_Pack_Upgrader extends WP_Upgrader { $language_updates_results[] = array( 'language' => $language_update->language, 'type' => $language_update->type, - 'slug' => isset( $language_update->slug ) ? $language_update->slug : 'default', + 'slug' => $language_update->slug ?? 'default', 'version' => $language_update->version, ); } diff --git a/wp-admin/includes/class-plugin-installer-skin.php b/wp-admin/includes/class-plugin-installer-skin.php index aa97833c59..13b4dd7097 100644 --- a/wp-admin/includes/class-plugin-installer-skin.php +++ b/wp-admin/includes/class-plugin-installer-skin.php @@ -45,7 +45,7 @@ class Plugin_Installer_Skin extends WP_Upgrader_Skin { $this->type = $args['type']; $this->url = $args['url']; - $this->api = isset( $args['api'] ) ? $args['api'] : array(); + $this->api = $args['api'] ?? array(); $this->overwrite = $args['overwrite']; parent::__construct( $args ); @@ -265,8 +265,8 @@ class Plugin_Installer_Skin extends WP_Upgrader_Skin { $blocked_message = '

' . esc_html__( 'The plugin cannot be updated due to the following:' ) . '

'; $blocked_message .= '