Normalize behavior between uploading in the media library and uploading directly to the block editor. Now, when uploading an image with a mime type the server does not support (either in the media library or the block editor), the user will see an error message “This image cannot be processed by the web server. Convert it to JPEG or PNG before uploading”.
Alos, add a new filter `wp_prevent_unsupported_mime_type_uploads` which determines whether the server should prevent uploads for image types it doesn't support. The default value is true and the filter also receives the uploaded image mime type.
Props: joomskys, adamsilverstein, azaozz, swissspidy, joemcgill, flixos90, audrasjb.
Fixes#61167
Built from https://develop.svn.wordpress.org/trunk@60084
git-svn-id: http://core.svn.wordpress.org/trunk@59420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the following GitHub Actions:
- `actions/upload-artifact` from `4.6.1` to `4.6.2`
- `actions/download-artifact` from `4.1.9` to `4.2.1`
- `actions/cache` from `4.2.2` to `4.2.3`
Though these are minor updates, they include a hardening change, switching to masking cache entry tokens in debug logs.
Fixes#62221.
Built from https://develop.svn.wordpress.org/trunk@60083
git-svn-id: http://core.svn.wordpress.org/trunk@59419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Currently, workflows are configured to only run for `wordpress-develop` or when pull requests are opened where forks and mirrors are the base repository.
Because a Dependabot configuration is present in the repository, it cannot be turned off for mirrors. This results in workflows running for all Dependabot PRs, which is problematic for private mirrors and needlessly consumes minutes and resources.
Props swissspidy, johnbillion.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@60080
git-svn-id: http://core.svn.wordpress.org/trunk@59416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset introduces a modification to the `get_params()` method within the WordPress REST API. The change ensures that the `rest_route` parameter is excluded from the parameters returned when pretty permalinks are not enabled. This update enhances the developer experience by ensuring that the parameters returned by `get_params()` are relevant and do not include unnecessary values, thereby reducing potential confusion and errors.
Props westonruter, TimothyBlynJacobs, audrasjb, debarghyabanerjee, dilip2615, shanemuir, peterwilsoncc.
Fixes#62163.
Built from https://develop.svn.wordpress.org/trunk@60073
git-svn-id: http://core.svn.wordpress.org/trunk@59409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This adds white space only changes made during 6.8 to the list of commits which we instruct git blame to ignore. Excluding them helps to reduce the noise when doing code archaeology.
Follow-up to [53007].
Props jorbin, peterwilsoncc.
See #62279.
Built from https://develop.svn.wordpress.org/trunk@60071
git-svn-id: http://core.svn.wordpress.org/trunk@59407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This adds the same logic to filter directive data attributes to ignore invalid data attributes that is applied in the client to avoid processing directives on the server that will not be processed in the client.
Props jonsurrell, SirLouen.
Fixes#62426.
Built from https://develop.svn.wordpress.org/trunk@60070
git-svn-id: http://core.svn.wordpress.org/trunk@59406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that not only the return values match the expected results, but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.
Follow-up to [48291], [50124], [57603].
See #62278.
Built from https://develop.svn.wordpress.org/trunk@60068
git-svn-id: http://core.svn.wordpress.org/trunk@59404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that not only the return values match the expected results, but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.
Follow-up to [39061], [48937].
See #62278.
Built from https://develop.svn.wordpress.org/trunk@60067
git-svn-id: http://core.svn.wordpress.org/trunk@59403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This expands the use of Dependabot to also manage npm dependencies by configuring several groups of related packages. After [59983], pull requests for the majority of these updates can now be staged without encountering test failures.
Props joemcgill, peterwilsoncc, swissspidy, johnbillion.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@60066
git-svn-id: http://core.svn.wordpress.org/trunk@59402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset fixes a edge case in `get_custom_logo()` where a page was set for the homepage without any front page in Settings > Reading and the `aria-current` attribute wasn't present on the logo link.
Props bschneidewind, audrasjb, siliconforks, sabernhardt, faisal03, shailu25, peterwilsoncc.
Fixes#62879.
Built from https://develop.svn.wordpress.org/trunk@60062
git-svn-id: http://core.svn.wordpress.org/trunk@59398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fix a PHP warning when opening a page directly in the site editor, eg by navigating to the URL `/wp-admin/site-editor.php?p=%2Fpage&postId=200`, caused by an undefined variable name.
Props abcd95, joemcgill, narenin, soyebsalar, websiteredev, wildworks.
Fixes#63122.
Built from https://develop.svn.wordpress.org/trunk@60061
git-svn-id: http://core.svn.wordpress.org/trunk@59397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This aims to facilitate setting up Xdebug locally without editing the `tools/local-env/php-config.ini` file, which is not ignored by Git by default.
Note that this does not enable Xdebug by default, since both `LOCAL_PHP_XDEBUG=true` and `LOCAL_PHP_XDEBUG_MODE=debug` are additionally required for Xdebug to work.
Props SirLouen, jules-colle, johnbillion, pento.
Fixes#49953.
Built from https://develop.svn.wordpress.org/trunk@60060
git-svn-id: http://core.svn.wordpress.org/trunk@59396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset removes the automatic addition of `rel="noopener"` from links targeting a new tab via `target="_blank"` in the `wp_list_bookmarks()` function. Since this was introduced, supported browsers have changed their security policies and no longer allow the opened link to have JavaScript access to the previous tab. This also removes the unit test cases previously located in `wpListBookmarks.php` as they were dedicated to test the presence of `rel="noopener"`.
Follow-up to [52061], [59120].
Props audrasjb, rvouill, marineevain, jeremy80.
Fixes#63096.
Built from https://develop.svn.wordpress.org/trunk@60058
git-svn-id: http://core.svn.wordpress.org/trunk@59394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This aims to facilitate setting up Xdebug locally without editing the `tools/local-env/php-config.ini` file, which is not ignored by Git by default.
Note that this does not enable Xdebug by default, since both `LOCAL_PHP_XDEBUG=true` and `LOCAL_PHP_XDEBUG_MODE=debug` are additionally required for Xdebug to work.
Props SirLouen, jules-colle, johnbillion, pento.
Fixes#49953.
Built from https://develop.svn.wordpress.org/trunk@60056
git-svn-id: http://core.svn.wordpress.org/trunk@59392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Address a failure in the customizer site logo cropping after r60031. Check to ensure library exists before the call to findWhere.
Follow up to r60031.
Props: domainsupport, joemcgill, joedolson, kawsar007, addweb-solution-pvt-ltd, mukesh27.
Fixes#63121.
Built from https://develop.svn.wordpress.org/trunk@60054
git-svn-id: http://core.svn.wordpress.org/trunk@59390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Because of how dependent jobs and queuing works in GitHub Actions, it’s common for workflows to be completed with the exception of sending Slack notifications.
“The waiting is the hardest part”, and occasionally these jobs hit the `10` minute timeout value before their turn comes up.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@60053
git-svn-id: http://core.svn.wordpress.org/trunk@59389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Because `pull_request_target` happens in the context of the base branch, attempting to checkout `github.head_ref` results in a failure when the workflow comes from a fork.
This adjusts the options passed to `actions/checkout` to use the repository that actually contains the test branch.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@60052
git-svn-id: http://core.svn.wordpress.org/trunk@59388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the following 3rd party actions:
- `actions/setup-node` from `4.2.0` to `4.3.0`
- `actions/upload-artifact` from `4.6.0` to `4.6.1`
- `ramsey/composer-install` from `3.0.0` to `3.1.0`
- `actions/cache` from `4.2.0` to `4.2.2`
- `actions/download-artifact` from `4.1.8` to `4.1.9`
- `codecov/codecov-action` from `5.3.1` to `5.4.0`
See #62221.
Built from https://develop.svn.wordpress.org/trunk@60051
git-svn-id: http://core.svn.wordpress.org/trunk@59387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Allow submenus in Twenty Twenty to be dismissed using the `esc` key to meet WCAG 1.4.13. Set focus to previous submenu parent on `esc`, and ensure that after escaping the last submenu, tab moves to the next parent item, not back into the submenu.
Props lcarevic, rcreators, pratiklondhe, poena, karmatosed, chaion07, audrasjb, mehdi01, mohonchandra, najmulsaju, saurabhdhariwal, ugyensupport, shailu25.
Fixes#49950.
Built from https://develop.svn.wordpress.org/trunk@60040
git-svn-id: http://core.svn.wordpress.org/trunk@59376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset updates the class used for the theme wrapper in the customizer, which fixes an alignment issue occuring when searching a theme on WordPress.org from the customizer interface.
Props kharisblank, ankitkumarshah, benazeer, sainathpoojary, mukesh27, kharisblank, parthvataliya, im3dabasia1, sukhendu2002, praful2111, ruchirj, imranhasanraaz, shailu25.
Fixes#62637.
Built from https://develop.svn.wordpress.org/trunk@60039
git-svn-id: http://core.svn.wordpress.org/trunk@59375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This is a follow-up to [59968] which improves error handling for when `wp_is_block_theme()` is called too early. Initially, `_doing_it_wrong()` was called in `WP_Theme::is_block_theme()` was called prior to themes being set up, in order to avoid the bug reported in #63062, where doing so would cause parent themes to not be resolved. After further investigation, the issue is only caused by calling `wp_is_block_theme()` before the root theme directory has been registered (e.g., when called on the `muplugins_loaded` hook).
Moving This error message to `wp_is_block_theme()` when `$GLOBALS['wp_theme_directories']` is empty avoids unnecessary error messages.
Props wildworks, sukhendu2002, SirLouen, dinhtungdu, narenin, joemcgill, peterwilsoncc, afragen.
Fixes#63086. See #63062.
Built from https://develop.svn.wordpress.org/trunk@60037
git-svn-id: http://core.svn.wordpress.org/trunk@59373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
