This commit protects against another multisite cache edge-case where a persistent object-cache drop-in plugin (namely memcached) may use a numerically-keyed `global_groups` array instead of `'key' => true` like the default object-cache class, and includes the following changes:
* Use `wp_is_numeric_array()` inside of `wp_cache_switch_to_blog_fallback()` so that the global group names array are always properly formatted regardless of the caching back-end in use
* Add private helper methods to `Tests_Multisite_WpCacheSwitchToBlogFallback` to properly format global group names, and tweak a few tests to make them more resilient to different caching back-ends
Follow up to r61760.
See #23290.
Built from https://develop.svn.wordpress.org/trunk@61772
git-svn-id: http://core.svn.wordpress.org/trunk@61078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The same error message was returned whether a user attempted bulk edit without selecting an action or attempted without selecting any posts. These two situations need different messages.
Return error messages appropriate to the actual user error.
Props Presskopp, r1k0, pratiknawkar94, joedolson.
Fixes#64659.
Built from https://develop.svn.wordpress.org/trunk@61771
git-svn-id: http://core.svn.wordpress.org/trunk@61077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In General Settings, set the `remove-site-icon` class in initial state and add border for clearer control boundaries.
Props sabernhardt, noruzzaman, madhavishah01, huzaifaalmesbah, hmbashar, shailu25, joedolson.
Fixes#64736.
Built from https://develop.svn.wordpress.org/trunk@61770
git-svn-id: http://core.svn.wordpress.org/trunk@61076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Switch the classic editor's taxonomy tabs to use the APG tablist/tabpanel structure. Add appropriate ARIA roles to tabs and panels and update JS to handle required keyboard events and selected states.
Props alh0319, mukesh27, joedolson.
Fixes#63981.
Built from https://develop.svn.wordpress.org/trunk@61764
git-svn-id: http://core.svn.wordpress.org/trunk@61070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Following the admin reskin, community events inputs were misaligned.
Change to `flex` layout to fix alignment and improve handling for translated strings.
Props huzaifaalmesbah, hmbashar, mirmpro, shailu25, joedolson.
Fixes#64753.
Built from https://develop.svn.wordpress.org/trunk@61761
git-svn-id: http://core.svn.wordpress.org/trunk@61067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit protects against an edge-case where a persistent object-cache drop-in plugin not including its own `wp_cache_switch_to_blog()` function would cause non-persistent cache groups to go missing when switching between sites, and includes the following changes:
* A new `wp_cache_switch_to_blog_fallback()` function in `ms-blogs.php` which abstracts duplicated code from `switch_to_blog()` and `restore_current_blog()` for easier unit testing
* A new `wpCacheSwitchToBlogFallback.php` file with approximately 25 new unit tests
* Conditionally declares `wp_cache_switch_to_blog()` in `cache-compat.php` only if it does not already exist, either via core's `cache.php` or a drop-in plugin
With this change, WordPress no longer needs to check if the `wp_cache_switch_to_blog()` function exists (because it always will) so those checks have been removed.
Props ethitter, jeremyfelt, johnjamesjacoby, markjaquith, nacin, ozgursar, r1k0.
Fixes#23290.
Built from https://develop.svn.wordpress.org/trunk@61760
git-svn-id: http://core.svn.wordpress.org/trunk@61066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Add a visible label with the `aria-label` value for image selection to enable voice control users to select images. Add visible labels on filters to improve access to media filters.
Props grahamarmfield, tomauger, afercia, rianrietveld, antpb, audrasjb, SirLouen, ozgursar, poojapadamad, mukesh27, alh0319, joedolson.
Fixes#23562.
Built from https://develop.svn.wordpress.org/trunk@61757
git-svn-id: http://core.svn.wordpress.org/trunk@61063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Adds `wp-includes/connectors.php` (loaded from `wp-settings.php`) and registers
a Settings > Connectors submenu when the AI client and Connectors admin page
renderer are available.
Registers connector API key settings in `/wp/v2/settings`, masks key values on
option reads, validates keys against provider configuration, and returns
`invalid_key` for explicitly requested connector fields when validation fails.
Stored connector keys are also passed to the AI client registry on init.
Gutenberg PR at https://github.com/WordPress/gutenberg/pull/75833.
Developed in https://github.com/WordPress/wordpress-develop/pull/11056.
Props jorgefilipecosta, gziolo, flixos90, justlevine, westonruter, jeffpaul, JasonTheAdams, audrasjb, shaunandrews, noruzzaman, mukesh27.
Fixes#64730.
Built from https://develop.svn.wordpress.org/trunk@61749
git-svn-id: http://core.svn.wordpress.org/trunk@61055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Remove the title attribute from `the_author_posts_link()` and related functions, retaining text for use in `the_author_posts_link` filter, and add parameter to disable title attributes in `the_author_link()`.
Default behavior will still differentiate the two links, but adds the option to remove all title attributes.
Props sabernhardt, alh0319, adnanlimdi, audrasjb, joedolson.
Fixes#62835. See #26559.
Built from https://develop.svn.wordpress.org/trunk@61745
git-svn-id: http://core.svn.wordpress.org/trunk@61051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Prevent the Twenty Twenty theme styles from overriding the Pullquote block's letter case settings.
Props paragjethva, hiteshtalpada, shailu25, poena, mukesh27, sukhendu2002, dhruvang21, ugyensupport, darshitrajyaguru97, sabernhardt, r1k0, joedolson.
Fixes#62773.
Built from https://develop.svn.wordpress.org/trunk@61743
git-svn-id: http://core.svn.wordpress.org/trunk@61049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Plugin and theme installer buttons load a dashicon during their updating and updated states. These dashicons were sized to large buttons, and caused a shift in alignment after the switch to compact buttons.
Update CSS to prevent shifts in size and alignment for installer buttons.
Props mohitbsf, peterwilsoncc, adnanhyder, huzaifaalmesbah, noruzzaman, ravichudasama01, shailu25, r1k0, joedolson.
Fixes#64687.
Built from https://develop.svn.wordpress.org/trunk@61741
git-svn-id: http://core.svn.wordpress.org/trunk@61047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The `aria-label` on post titles in list tables changes the accessible name from `{post_title}` to `"{post_title}" (Edit)`. This change increases verbosity for screen readers and creates a mismatch between the visual text and the accessible name for voice command.
Remove the extraneous `aria-label`.
Props afercia, rianrietveld, iworks, muddassirnasim, joedolson.
Fixes#33002.
Built from https://develop.svn.wordpress.org/trunk@61738
git-svn-id: http://core.svn.wordpress.org/trunk@61044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The admin reskin changed info notices to a transparent background, matching usage in Gutenberg. But with the gray background in the core admin, these notices didn't show up in an expected manner. Additionally, using a transparent background in a context where the background color is variable is risky for color contrast.
Change `.notice-info`, `.notice-info.notice-alt`, and `.login .notice, .login .message` to use white backgrounds. Reverts changes from [61731] to apply styles also to `.message` class.
Props mohitbsf, audrasjb, peterwilsoncc, pbiron, fabiankaegy, noruzzaman, joedolson.
Fixes#64678. See #64715.
Built from https://develop.svn.wordpress.org/trunk@61737
git-svn-id: http://core.svn.wordpress.org/trunk@61043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Refines the Navigation Overlay template description to remove the "full-screen" assumption and clarify that the overlay can be toggled open and closed.
Follow-up to [61609].
Props get_dave, scruffian, wildworks.
See #64589.
Built from https://develop.svn.wordpress.org/trunk@61734
git-svn-id: http://core.svn.wordpress.org/trunk@61041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The `wp_install_maybe_enable_pretty_permalinks()` function usually enables pretty permalinks during installation, but it relies on a loopback request that may not work on all development environments.
In temporary lieu of fixing the underlying loopback request on all the container images, this switches to explictly enabling permalinks and removes redundant permalink configuration from GitHub Actions workflow files.
See #64227
Built from https://develop.svn.wordpress.org/trunk@61733
git-svn-id: http://core.svn.wordpress.org/trunk@61040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset standardizes the vertical spacing between the heading and the first content item in the “At a Glance” admin dashboard widget to match the spacing conventions used by other dashboard widgets.
Props mohitbsf, opurockey, adnanhyder.
Fixes#64682.
Built from https://develop.svn.wordpress.org/trunk@61732
git-svn-id: http://core.svn.wordpress.org/trunk@61039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Following the admin reskin, the Copy link button for sharing customizer previews was misaligned.
Override core button disabled styles to set transform and background properties. Fix shadow height.
Props mohitbsf, audrasjb, hbhalodia, huzaifaalmesbah, sajib1223, joedolson.
Fixes#64688.
Built from https://develop.svn.wordpress.org/trunk@61730
git-svn-id: http://core.svn.wordpress.org/trunk@61037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Following the admin reskin, the larger buttons in plugin cards caused an existing potential for text overlap to happen more easily. Switching to compact size restores prior behavior.
Props hiroshisato, audrasjb, huzaifaalmesbah, shailu25, joedolson.
Fixes#64686.
Built from https://develop.svn.wordpress.org/trunk@61729
git-svn-id: http://core.svn.wordpress.org/trunk@61036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
