Joe McGill 682ec35fbc Media: Ensure 'media_handle_upload()' returns 'WP_Error' on failure. ...

This fixes an issue where failures when inserting the attachment post via
`wp_insert_attachment()` would result in a return value of `0` instead of a
`WP_Error` object, as documented. This is addressed by passing `true` as the 
fourth param (added in WP 4.7.0) when calling `wp_insert_attachment()`.

Props mrasharirfan, flixos90.
Fixes #41726.

Built from https://develop.svn.wordpress.org/trunk@41323


git-svn-id: http://core.svn.wordpress.org/trunk@41154 1a063a9b-81f0-0310-95a4-ce76da25c4cd

2017-08-30 15:04:48 +00:00

..

admin-filters.php

Options, Meta APIs: Require a confirmation link in an email to be clicked when an admin attempts to change the site admin email address.

2017-08-14 20:13:43 +00:00

admin.php

Bootstrap: do not go gentle into that good night r38411, r38412, and parts of r38389.

2016-08-31 16:31:29 +00:00

ajax-actions.php

Widgets: Correctly strip slashes from widget and sidebar names to allow namespaced widgets to function correctly.

2017-08-22 14:52:44 +00:00

bookmark.php

…

class-automatic-upgrader-skin.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-bulk-plugin-upgrader-skin.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-bulk-theme-upgrader-skin.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-bulk-upgrader-skin.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-core-upgrader.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

class-file-upload-upgrader.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

class-ftp-pure.php

FTP: ensure that there is only one class named ftp, which is what is expected in the loading of this arcane library. This ensures that an autoload generator, something along the lines of Composer, won't hiccup when it gets to these files.

2016-08-26 18:47:29 +00:00

class-ftp-sockets.php

FTP: ensure that there is only one class named ftp, which is what is expected in the loading of this arcane library. This ensures that an autoload generator, something along the lines of Composer, won't hiccup when it gets to these files.

2016-08-26 18:47:29 +00:00

class-ftp.php

Bootstrap: do not go gentle into that good night r38411, r38412, and parts of r38389.

2016-08-31 16:31:29 +00:00

class-language-pack-upgrader-skin.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-language-pack-upgrader.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

class-pclzip.php

…

class-plugin-installer-skin.php

Plugins: Introduce singular capabilities for activating and deactivating individual plugins.

2017-08-22 14:02:44 +00:00

class-plugin-upgrader-skin.php

Plugins: Introduce singular capabilities for activating and deactivating individual plugins.

2017-08-22 14:02:44 +00:00

class-plugin-upgrader.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

class-theme-installer-skin.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-theme-upgrader-skin.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-theme-upgrader.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

class-walker-category-checklist.php

General: Fix more instances of inconsistent parameters passed to various filters, plus fix some filter docs.

2017-08-03 16:13:44 +00:00

class-walker-nav-menu-checklist.php

…

class-walker-nav-menu-edit.php

Menus: Visually hide the menu item edit link text in a consistent way.

2017-08-03 22:12:43 +00:00

class-wp-ajax-upgrader-skin.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-automatic-updater.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

class-wp-comments-list-table.php

Docs: Remove some more top-level @aacess tags from function DocBlocks.

2017-07-27 08:19:43 +00:00

class-wp-community-events.php

Dashboard: Discontinue nonessential logging of Events API requests.

2017-08-25 18:12:44 +00:00

class-wp-filesystem-base.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-filesystem-direct.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-filesystem-ftpext.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-filesystem-ftpsockets.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-filesystem-ssh2.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-importer.php

Docs: Use a third-person singular verb in the DocBlock summary for WP_Importer::stop_the_insanity().

2017-07-30 15:46:43 +00:00

class-wp-internal-pointers.php

…

class-wp-links-list-table.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-list-table-compat.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-list-table.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-media-list-table.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-ms-sites-list-table.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

class-wp-ms-themes-list-table.php

General: Fix a typo introduced in [41219].

2017-08-03 15:46:44 +00:00

class-wp-ms-users-list-table.php

Docs: Reduce confusion in @since MU notationss by indicating the WP version (3.0.0) the code was merged into core while retaining the original context.

2017-08-01 20:44:43 +00:00

class-wp-plugin-install-list-table.php

Plugins: Introduce singular capabilities for activating and deactivating individual plugins.

2017-08-22 14:02:44 +00:00

class-wp-plugins-list-table.php

Plugins: Introduce singular capabilities for activating and deactivating individual plugins.

2017-08-22 14:02:44 +00:00

class-wp-post-comments-list-table.php

…

class-wp-posts-list-table.php

General: Fix various instances of incorrect filter docs and incorrect filter and action parameters.

2017-08-03 15:43:43 +00:00

class-wp-press-this.php

General: Fix various instances of incorrect filter docs and incorrect filter and action parameters.

2017-08-03 15:43:43 +00:00

class-wp-screen.php

Docs: Correct description for view_mode_post_types filter added in [35357].

2017-08-25 19:27:45 +00:00

class-wp-site-icon.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-terms-list-table.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-theme-install-list-table.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-themes-list-table.php

General: Fix various instances of incorrect filter docs and incorrect filter and action parameters.

2017-08-03 15:43:43 +00:00

class-wp-upgrader-skin.php

Docs: Remove @access notations from method DocBlocks in wp-admin/* classes.

2017-07-27 00:40:43 +00:00

class-wp-upgrader-skins.php

Load: Re-add class-wp-upgrader-skins.php.

2016-12-03 03:40:41 +00:00

class-wp-upgrader.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

class-wp-users-list-table.php

Users: After [41027], assign $author_posts_url outside of the condition to simplify the logic.

2017-07-28 14:21:45 +00:00

comment.php

…

continents-cities.php

…

credits.php

I18N: Introduce a user-specific language setting.

2016-10-03 07:04:29 +00:00

dashboard.php

Docs: Reduce confusion in @since MU notationss by indicating the WP version (3.0.0) the code was merged into core while retaining the original context.

2017-08-01 20:44:43 +00:00

deprecated.php

Docs: Add a missing return description for the deprecated get_screen_icon() function.

2017-08-20 04:04:44 +00:00

edit-tag-messages.php

…

export.php

Docs: Add missing backtick character in export_wp() DocBlock.

2017-06-27 00:58:41 +00:00

file.php

Filesystem: Introduce the pre_move_uploaded_file filter.

2017-08-16 21:59:43 +00:00

image-edit.php

Media: Rename several attachment related parameters from $post_id to $attachment_id for clarity, and improve related

2017-08-22 11:12:44 +00:00

image.php

Docs: Fix various filter documentation.

2017-08-03 14:34:44 +00:00

import.php

I18N: Introduce a user-specific language setting.

2016-10-03 07:04:29 +00:00

list-table.php

Bootstrap: do not go gentle into that good night r38411, r38412, and parts of r38389.

2016-08-31 16:31:29 +00:00

media.php

Media: Ensure 'media_handle_upload()' returns 'WP_Error' on failure.

2017-08-30 15:04:48 +00:00

menu.php

…

meta-boxes.php

Introduce most_used taxonomy label, for text on 'Most Used' metabox tab.

2017-07-01 14:46:41 +00:00

misc.php

Options, Meta APIs: Require a confirmation link in an email to be clicked when an admin attempts to change the site admin email address.

2017-08-14 20:13:43 +00:00

ms-admin-filters.php

Options, Meta APIs: Require a confirmation link in an email to be clicked when an admin attempts to change the site admin email address.

2017-08-14 20:13:43 +00:00

ms-deprecated.php

Docs: Standardize and add missing deprecation notations in DocBlocks for the following functions:

2017-06-22 17:48:45 +00:00

ms.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

nav-menu.php

Accessibility: Improve the Menus post type meta boxes pagination links.

2016-10-27 15:23:31 +00:00

network.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

noop.php

Docs: Add missing file header to wp-admin/includes/noop.php, introduced in [34037].

2017-01-25 23:10:43 +00:00

options.php

Accessibility: Avoid a keyboard trap on the permalink custom structure setting.

2017-06-12 14:09:43 +00:00

plugin-install.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

plugin.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

post.php

Post Formats: In bulk_edit_posts(), set post format before the post is updated, for consistency with edit_post().

2017-07-30 14:41:42 +00:00

revision.php

I18N: Correct various instances of incorrect usage of esc_attr_e().

2016-08-28 18:06:30 +00:00

schema.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

screen.php

…

taxonomy.php

…

template.php

General: Fix more instances of inconsistent parameters passed to various filters, plus fix some filter docs.

2017-08-03 16:13:44 +00:00

theme-install.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

theme.php

Customize: Prevent links to customize.php from being generated which have query vars from wp_removable_query_args() present.

2017-03-22 23:04:42 +00:00

translation-install.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

update-core.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

update.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

upgrade.php

General: Improve terminology used when referring to installations of WordPress and its extensions.

2017-08-22 11:52:48 +00:00

user.php

Users: Use more appropriate HTTP status codes for errors relating to user management.

2017-06-25 18:46:44 +00:00

widgets.php

Accessibility: Make some Widgets buttons real buttons.

2017-04-19 21:14:44 +00:00