HostForge-Systems/wordpress
Template
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
4bfc1358a05ff1fdd7d60944f8065c36c861c597
wordpress/wp-includes
History
Sergey Biryukov 4bfc1358a0 Posts, Post Types: Correct the check for non-existing post in get_post_permalink(). 
The function was erroneously calling `is_wp_error()` on the result of a `get_post()` call, which returns `null` on failure, and never returns a `WP_Error` object.

Previously, passing a non-existing post ID to the function would result in a home URL being returned and a few `Attempt to read property "post_type, post_name, hierarchical..." on null` PHP warnings.

This commit ensures `get_post_permalink()` returns `false` on failure, which brings parity with `get_permalink()`.

Includes a unit test to confirm the correct behavior.

Follow-up to [12923], [13023], [32606].

Props renegeuze, manzoorwani.jk.
Fixes #45329.
Built from https://develop.svn.wordpress.org/trunk@53733


git-svn-id: http://core.svn.wordpress.org/trunk@53292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-07-20 15:41:09 +00:00
..
assets
Editor: Update block editor packages for WordPress 6.0.1.
2022-07-05 14:38:33 +00:00
block-patterns
REST API: Bring new endpoints for Block Patterns from Gutenberg plugin
2022-04-12 09:26:16 +00:00
block-supports
Editor: Add utility classnames back to blocks that have layout attributes specified.
2022-06-23 23:09:09 +00:00
blocks
Tools: Automate backporting core blocks from Gutenberg to Core
2022-07-08 12:34:14 +00:00
certificates
…
css
Editor: Update block editor packages for WordPress 6.0.1.
2022-07-04 12:06:43 +00:00
customize
General: Replace all esc_url_raw() calls in core with sanitize_url().
2022-06-01 18:14:10 +00:00
fonts
…
ID3
…
images
…
IXR
…
js
External Libraries: Update the Moment library to version 2.29.4.
2022-07-19 19:43:25 +00:00
php-compat
Docs: Adjust some deprecated function DocBlocks per the [https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#1-2-deprecated-functions documentation standards].
2022-04-06 15:20:06 +00:00
PHPMailer
External Libraries: Upgrade PHPMailer to version 6.6.3.
2022-06-20 15:04:11 +00:00
pomo
Docs: Remove @return void from various DocBlocks.
2022-05-02 13:13:08 +00:00
random_compat
External Libraries: Update random_compat to version 2.0.21.
2022-02-16 21:19:04 +00:00
Requests
…
rest-api
Coding Standards: Standardize on user_id when passing data to comment functions.
2022-07-20 14:14:09 +00:00
SimplePie
…
sitemaps
Docs: Add missing @since mention in get_posts_query_args().
2022-06-21 13:48:12 +00:00
sodium_compat
Upgrade/Install: Update sodium_compat to v1.17.1.
2022-03-24 15:20:08 +00:00
Text
Administration: Replace contracted verb forms for better consistency.
2022-03-22 16:25:03 +00:00
theme-compat
Administration: Replace contracted verb forms for better consistency.
2022-03-22 16:25:03 +00:00
widgets
Widgets: Add a comment in WP_Nav_Menu_Widget::form() to clarify the esc_attr() usage.
2022-07-01 20:01:15 +00:00
admin-bar.php
Toolbar: Add a filter to help remove site icons from toolbar for large multisite, and lazy load them by default.
2022-04-07 22:14:05 +00:00
atomlib.php
Code Modernization: Rename parameters that use reserved keywords in wp-includes/atomlib.php.
2022-04-21 11:24:17 +00:00
author-template.php
I18N: Use a translatable string for displaying a user's first name and last name.
2022-06-14 14:43:12 +00:00
block-editor.php
Editor: Fix opinionated block styles loading in editor
2022-05-20 11:42:19 +00:00
block-i18n.json
…
block-patterns.php
Editor: Fix core 'Featured' pattern category registration
2022-04-29 14:10:09 +00:00
block-template-utils.php
Docs: Use third-person singular verbs for function descriptions in block-template.php and block-template-utils.php.
2022-07-20 13:21:08 +00:00
block-template.php
Docs: Use third-person singular verbs for function descriptions in block-template.php and block-template-utils.php.
2022-07-20 13:21:08 +00:00
blocks.php
Editor: Fix register_block_type does not recognise ancestor block setting
2022-07-19 13:24:12 +00:00
bookmark-template.php
Docs: Use third-person singular verbs for function descriptions in Bookmark related files, as per docblock standards.
2022-06-23 22:57:12 +00:00
bookmark.php
Docs: Use third-person singular verbs for function descriptions in Bookmark related files, as per docblock standards.
2022-06-23 22:57:12 +00:00
cache-compat.php
Docs: Replace Codex links with the corresponding page on DevHub.
2022-04-18 15:08:09 +00:00
cache.php
Docs: Replace Codex links with the corresponding page on DevHub.
2022-04-18 15:08:09 +00:00
canonical.php
Canonical: Include all public status in 404 redirects.
2022-04-01 03:25:01 +00:00
capabilities.php
Docs: Use third-person singular verbs for method descriptions in wp-includes/class-wp-roles.php, per the documentation standards.
2022-05-23 15:01:12 +00:00
category-template.php
Posts, Post Types: Standardize on $post parameter name where appropriate.
2022-07-18 17:37:17 +00:00
category.php
…
class-feed.php
…
class-http.php
General: Use WPINC as a shorter reference to wp-includes in some files.
2022-06-17 11:20:13 +00:00
class-IXR.php
…
class-json.php
…
class-oembed.php
General: Use WPINC as a shorter reference to wp-includes in some files.
2022-06-17 11:20:13 +00:00
class-phpass.php
…
class-phpmailer.php
…
class-pop3.php
…
class-requests.php
…
class-simplepie.php
…
class-smtp.php
…
class-snoopy.php
…
class-walker-category-dropdown.php
…
class-walker-category.php
…
class-walker-comment.php
…
class-walker-nav-menu.php
…
class-walker-page-dropdown.php
Coding standards: Remove extra spaces in docblocks of the Walker_PageDropdown class.
2022-05-01 22:01:10 +00:00
class-walker-page.php
…
class-wp-admin-bar.php
…
class-wp-ajax-response.php
…
class-wp-application-passwords.php
Docs: Convert "Application Passwords" to lowercase in WP_Application_Passwords docblocks, for better consistency.
2022-07-06 11:55:11 +00:00
class-wp-block-editor-context.php
Add WP_Block_Editor_Context::$name
2022-03-17 03:37:05 +00:00
class-wp-block-list.php
…
class-wp-block-parser.php
…
class-wp-block-pattern-categories-registry.php
Editor: Return additional block patterns to server-generated settings
2022-05-17 14:38:14 +00:00
class-wp-block-patterns-registry.php
Coding Standards: Correct alignment in various files.
2022-05-23 20:40:14 +00:00
class-wp-block-styles-registry.php
…
class-wp-block-supports.php
…
class-wp-block-template.php
…
class-wp-block-type-registry.php
…
class-wp-block-type.php
Editor: Register 'lock' attribute for every block on the server
2022-04-26 09:50:12 +00:00
class-wp-block.php
…
class-wp-comment-query.php
Docs: Add a comment for stripping the leading AND from SQL clauses in some query classes.
2022-06-14 16:17:08 +00:00
class-wp-comment.php
…
class-wp-customize-control.php
…
class-wp-customize-manager.php
General: Replace all esc_url_raw() calls in core with sanitize_url().
2022-06-01 18:14:10 +00:00
class-wp-customize-nav-menus.php
Docs: Remove @return void from various DocBlocks.
2022-05-02 13:13:08 +00:00
class-wp-customize-panel.php
…
class-wp-customize-section.php
…
class-wp-customize-setting.php
Code Modernization: Rename parameters that use reserved keywords in swp-includes/class-wp-customize-setting.php.
2022-04-24 00:28:08 +00:00
class-wp-customize-widgets.php
Code Modernization: Rename parameters that use reserved keywords in wp-includes/class-wp-customize-widgets.php.
2022-04-25 13:29:09 +00:00
class-wp-date-query.php
…
class-wp-dependency.php
…
class-wp-editor.php
Docs: Various docblock improvements.
2022-04-28 09:46:21 +00:00
class-wp-embed.php
Code Modernization: Rename parameters that use reserved keywords in wp-includes/class-wp-embed.php.
2022-04-26 10:00:09 +00:00
class-wp-error.php
Docs: Various docblock improvements.
2022-04-28 09:46:21 +00:00
class-wp-fatal-error-handler.php
Docs: Corrections and improvements to docblocks for function and hooks relating to fatal error handling.
2022-04-29 19:17:11 +00:00
class-wp-feed-cache-transient.php
…
class-wp-feed-cache.php
…
class-wp-hook.php
…
class-wp-http-cookie.php
…
class-wp-http-curl.php
Coding Standards: Use strict comparison in wp-includes/class-wp-http-curl.php.
2022-03-20 16:24:03 +00:00
class-wp-http-encoding.php
…
class-wp-http-ixr-client.php
…
class-wp-http-proxy.php
…
class-wp-http-requests-hooks.php
…
class-wp-http-requests-response.php
…
class-wp-http-response.php
…
class-wp-http-streams.php
Docs: Correct method reference format in some DocBlocks.
2022-06-06 10:51:12 +00:00
class-wp-http.php
Coding Standards: Rename the $strResponse variable to $response in WP_Http_Streams::request().
2022-03-20 16:02:04 +00:00
class-wp-image-editor-gd.php
Docs: Improve documentation for WP_Image_Editor::save() and related functions.
2022-06-21 11:18:17 +00:00
class-wp-image-editor-imagick.php
Docs: Improve documentation for WP_Image_Editor::save() and related functions.
2022-06-21 11:18:17 +00:00
class-wp-image-editor.php
Docs: Improve documentation for WP_Image_Editor::save() and related functions.
2022-06-21 11:18:17 +00:00
class-wp-list-util.php
…
class-wp-locale-switcher.php
…
class-wp-locale.php
I18N: Avoid translating wp_locale strings several times.
2022-03-18 21:18:03 +00:00
class-wp-matchesmapregex.php
…
class-wp-meta-query.php
…
class-wp-metadata-lazyloader.php
…
class-wp-network-query.php
Coding Standards: Restore the $pieces variable for SQL clauses in query classes.
2022-05-10 11:21:09 +00:00
class-wp-network.php
Coding Standards: Fix params indentation in pre_get_network_by_path hook docblock.
2022-05-15 20:32:08 +00:00
class-wp-object-cache.php
Docs: Improve @return tags for wp_cache_*_multiple() functions:
2022-02-11 19:21:01 +00:00
class-wp-oembed-controller.php
…
class-wp-oembed.php
Docs: Update the version in which Meetup.com was removed as an oEmbed source.
2022-07-04 18:15:15 +00:00
class-wp-paused-extensions-storage.php
Docs: Corrections and improvements to docblocks for function and hooks relating to fatal error handling.
2022-04-29 19:17:11 +00:00
class-wp-post-type.php
Docs: Improve doc blocks for hooks added in [53126].
2022-04-13 03:04:10 +00:00
class-wp-post.php
Docs: Correct the type for WP_Post::$post_category and ::$tags_input.
2022-05-21 12:07:13 +00:00
class-wp-query.php
REST API: Some documentation and test improvements for update_menu_item_cache():
2022-06-15 13:37:10 +00:00
class-wp-recovery-mode-cookie-service.php
…
class-wp-recovery-mode-email-service.php
Docs: Corrections and improvements to docblocks for function and hooks relating to fatal error handling.
2022-04-29 19:17:11 +00:00
class-wp-recovery-mode-key-service.php
…
class-wp-recovery-mode-link-service.php
Docs: Add missing description for $pagenow global in various functions.
2022-04-04 18:26:06 +00:00
class-wp-recovery-mode.php
Docs: Corrections and improvements to docblocks for function and hooks relating to fatal error handling.
2022-04-29 19:17:11 +00:00
class-wp-rewrite.php
…
class-wp-role.php
…
class-wp-roles.php
Docs: Use third-person singular verbs for method descriptions in wp-includes/class-wp-roles.php, per the documentation standards.
2022-05-23 15:01:12 +00:00
class-wp-session-tokens.php
…
class-wp-simplepie-file.php
…
class-wp-simplepie-sanitize-kses.php
…
class-wp-site-query.php
Docs: Add a comment for stripping the leading AND from SQL clauses in some query classes.
2022-06-14 16:17:08 +00:00
class-wp-site.php
…
class-wp-tax-query.php
Taxonomy: Improve performance by taxonomy queries by adding a limitting requested terms.
2022-03-31 10:06:01 +00:00
class-wp-taxonomy.php
Docs: Improve doc blocks for hooks added in [53126].
2022-04-13 03:04:10 +00:00
class-wp-term-query.php
Docs: Add a comment for stripping the leading AND from SQL clauses in some query classes.
2022-06-14 16:17:08 +00:00
class-wp-term.php
…
class-wp-text-diff-renderer-inline.php
…
class-wp-text-diff-renderer-table.php
…
class-wp-theme-json-resolver.php
Docs: Various docblock corrections and improvements for changes introduced in 6.0.
2022-04-28 09:59:13 +00:00
class-wp-theme-json-schema.php
…
class-wp-theme-json.php
Docs: Various docblock corrections and improvements for changes introduced in 6.0.
2022-04-28 09:59:13 +00:00
class-wp-theme.php
Text Changes: Improve consistency of punctuation in some strings.
2022-07-14 14:10:11 +00:00
class-wp-user-meta-session-tokens.php
…
class-wp-user-query.php
Users: Prime user meta in WP_User_Query class.
2022-07-05 09:28:13 +00:00
class-wp-user-request.php
…
class-wp-user.php
Docs: Use third-person singular verbs for function descriptions in wp-includes/class-wp-user.php.
2022-03-07 13:07:03 +00:00
class-wp-walker.php
Docs: Clarify the name and description of some parameters in the Walker class.
2022-05-01 21:47:10 +00:00
class-wp-widget-factory.php
…
class-wp-widget.php
…
class-wp-xmlrpc-server.php
Coding Standards: Standardize on user_id when passing data to comment functions.
2022-07-20 14:14:09 +00:00
class-wp.php
Feeds: Use latest comment date for the Last-Modified header of comments feed.
2022-04-20 12:47:11 +00:00
class.wp-dependencies.php
Code Modernization: Rename parameters that use reserved keywords in wp-includes/class-wp-query.php.
2022-04-26 14:28:08 +00:00
class.wp-scripts.php
Script Loader: Explain why i18n prevents concatenation.
2022-05-08 23:59:11 +00:00
class.wp-styles.php
Code Modernization: Rename parameters that use reserved keywords in wp-includes/class.wp-styles.php.
2022-04-26 14:59:08 +00:00
comment-template.php
Coding Standards: Rename $comment_post_ID and $comment_author_IP variables in various files.
2022-07-19 16:19:11 +00:00
comment.php
Coding Standards: Remove extra comma in a compact() call.
2022-07-20 14:22:08 +00:00
compat.php
Code Modernization: Rename parameters to match native PHP functions in wp-includes/compat.php.
2022-05-08 00:29:14 +00:00
cron.php
…
date.php
General: Use WPINC as a shorter reference to wp-includes in some files.
2022-06-17 11:20:13 +00:00
default-constants.php
Formatting: Add support for formatting sizes as PB, EB, ZB, and YB.
2022-03-18 20:48:02 +00:00
default-filters.php
General: Replace all esc_url_raw() calls in core with sanitize_url().
2022-06-01 18:14:10 +00:00
default-widgets.php
…
deprecated.php
Posts, Post Types: Standardize on $post parameter name where appropriate.
2022-07-18 17:37:17 +00:00
embed-template.php
General: Use WPINC as a shorter reference to wp-includes in some files.
2022-06-17 11:20:13 +00:00
embed.php
Posts, Post Types: Standardize on $post parameter name where appropriate.
2022-07-18 17:37:17 +00:00
error-protection.php
Docs: Corrections and improvements to docblocks for function and hooks relating to fatal error handling.
2022-04-29 19:17:11 +00:00
feed-atom-comments.php
…
feed-atom.php
…
feed-rdf.php
…
feed-rss2-comments.php
…
feed-rss2.php
…
feed-rss.php
…
feed.php
Docs: Use third-person singular verbs for function descriptions in the Feed API, as per docblock standards.
2022-06-20 21:46:16 +00:00
formatting.php
General: Replace all esc_url_raw() calls in core with sanitize_url().
2022-06-01 18:14:10 +00:00
functions.php
Text Changes: Improve consistency of punctuation in some strings.
2022-07-14 14:10:11 +00:00
functions.wp-scripts.php
Docs: Add missing description for $pagenow global in various functions.
2022-04-04 18:26:06 +00:00
functions.wp-styles.php
…
general-template.php
Posts, Post Types: Standardize on $post parameter name where appropriate.
2022-07-18 17:37:17 +00:00
global-styles-and-settings.php
Editor: Backport Duotone fixes for 5.9.1.
2022-02-17 16:18:03 +00:00
http.php
HTTP API: Fix typo in and improve readability of wp_parse_url() docblock.
2022-03-10 16:02:01 +00:00
https-detection.php
…
https-migration.php
…
kses.php
KSES: Document HTML allow list is in lowercase.
2022-03-31 03:54:02 +00:00
l10n.php
Coding Standards: Rename the $user_id parameter of get_user_locale() to $user for accuracy.
2022-07-15 13:45:11 +00:00
link-template.php
Posts, Post Types: Correct the check for non-existing post in get_post_permalink().
2022-07-20 15:41:09 +00:00
load.php
Text Changes: Improve consistency of admin error notices.
2022-06-02 15:05:13 +00:00
locale.php
…
media-template.php
…
media.php
Posts, Post Types: Standardize on $post parameter name where appropriate.
2022-07-18 17:37:17 +00:00
meta.php
Cache: Use wp_cache_*_multiple() in core functions.
2022-02-11 18:51:59 +00:00
ms-blogs.php
…
ms-default-constants.php
I18N: Remove code from a translatable string in wp-includes/ms-default-constants.php.
2022-07-14 13:35:13 +00:00
ms-default-filters.php
Users: Introduce the concept of a large site to single site installations.
2022-03-29 12:42:13 +00:00
ms-deprecated.php
Text Changes: Improve consistency of admin error notices.
2022-06-02 15:05:13 +00:00
ms-files.php
…
ms-functions.php
Docs: Typo correction in wp-includes/ms-functions.php docblock.
2022-04-25 09:25:09 +00:00
ms-load.php
Database: Use generic references to a database server in ms_not_installed().
2022-05-13 12:21:13 +00:00
ms-network.php
Cache: Use wp_cache_*_multiple() in core functions.
2022-02-11 18:51:59 +00:00
ms-settings.php
…
ms-site.php
Docs: Update the DocBlock for the wpmu_new_blog action to suggest wp_initialize_site as an alternative.
2022-03-03 16:13:03 +00:00
nav-menu-template.php
…
nav-menu.php
REST API: Some documentation and test improvements for update_menu_item_cache():
2022-06-15 13:37:10 +00:00
option.php
Docs: Correct @since tags introduced in WordPress 6.0.1.
2022-07-15 16:00:10 +00:00
pluggable-deprecated.php
…
pluggable.php
Users: Allow conditional supression of the email notifications that are sent when a new user account is registered.
2022-07-12 21:05:16 +00:00
plugin.php
Plugins: Convert apply_filters() into a proper variadic function.
2022-03-18 18:23:04 +00:00
post-formats.php
…
post-template.php
Posts, Post Types: Standardize on $post parameter name where appropriate.
2022-07-18 17:37:17 +00:00
post-thumbnail-template.php
Docs: Misc. fixes in wp-includes/post-template.php and wp-includes/post-thumbnail-template.php.
2022-03-15 15:22:05 +00:00
post.php
Coding Standards: Rename $comment_post_ID and $comment_author_IP variables in various files.
2022-07-19 16:19:11 +00:00
query.php
Posts, Post Types: Add caching to _find_post_by_old_slug and _find_post_by_old_date functions.
2022-06-21 13:34:13 +00:00
registration-functions.php
…
registration.php
…
rest-api.php
General: Replace all esc_url_raw() calls in core with sanitize_url().
2022-06-01 18:14:10 +00:00
revision.php
Posts, Post Types: Standardize on $post parameter name where appropriate.
2022-07-18 17:37:17 +00:00
rewrite.php
Docs: Use third-person singular verbs for function descriptions in wp-includes/rewrite.php, per the documentation standards.
2022-03-25 21:34:01 +00:00
robots-template.php
Docs: Adjust DocBlock formatting for wp_robots_*() and related functions.
2022-04-06 15:33:03 +00:00
rss-functions.php
…
rss.php
Administration: Replace contracted verb forms for better consistency.
2022-03-22 16:25:03 +00:00
script-loader.php
External Libraries: Update the Moment library to version 2.29.4.
2022-07-19 19:43:25 +00:00
session.php
…
shortcodes.php
Docs: Misc fixes in Shortcode API function and hook descriptions, as per documentation standards.
2022-06-28 20:37:15 +00:00
sitemaps.php
…
spl-autoload-compat.php
…
taxonomy.php
Taxonomy: Retain default term option when unregistering taxos.
2022-07-06 05:11:12 +00:00
template-canvas.php
…
template-loader.php
…
template.php
Themes: Add actions to template loading to assist with collecting debug info.
2022-06-23 18:59:09 +00:00
theme-i18n.json
Themes: Add "title" key to i18n schema
2022-03-31 10:53:04 +00:00
theme-templates.php
Docs: Remove @return void from various DocBlocks.
2022-05-02 13:13:08 +00:00
theme.json
Administration: Revert unwanted spaces found in theme.json after [53131].
2022-04-11 11:55:00 +00:00
theme.php
Docs: Correct @since tags introduced in WordPress 6.0.1.
2022-07-15 16:00:10 +00:00
update.php
General: Replace all esc_url_raw() calls in core with sanitize_url().
2022-06-01 18:14:10 +00:00
user.php
I18N: Use a translatable string for displaying a user's first name and last name.
2022-06-14 14:43:12 +00:00
vars.php
Bootstrap/Load: Avoid a PHP warning when setting the $pagenow global in wp-includes/vars.php.
2022-04-27 13:47:11 +00:00
version.php
Posts, Post Types: Correct the check for non-existing post in get_post_permalink().
2022-07-20 15:41:09 +00:00
widgets.php
General: Replace all esc_url_raw() calls in core with sanitize_url().
2022-06-01 18:14:10 +00:00
wlwmanifest.xml
…
wp-db.php
Coding Standards: Simplify the logic for setting DB host and port in wpdb::parse_db_host().
2022-07-06 10:32:12 +00:00
wp-diff.php
…