Gary Pendergast 69147eb345 Database: Split the logic of wpdb::init_charset() into a separate method. ...

The logic for determining the appropriate character set and collation to use is becoming more complex, particularly with the recent additions of [37522] and [37523]. As `init_charset()` has side effects, and makes use of constants instead of parameters, it's not possible to unit test this logic.

This commit splits the logic part of `init_charset()` out into a new method, `wpdb::determine_charset()`, along with appropriate unit tests.

See #32105, #37522.

Fixes #36917.


Built from https://develop.svn.wordpress.org/trunk@37601


git-svn-id: http://core.svn.wordpress.org/trunk@37569 1a063a9b-81f0-0310-95a4-ce76da25c4cd

2016-06-01 02:38:29 +00:00

..

certificates

Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.

2016-05-13 18:41:31 +00:00

css

System font: The stack does not work with the font shorthand property.

2016-05-17 01:45:27 +00:00

customize

Docs: Apply inline @see tags to hooks referenced in DocBlocks for core classes.

2016-05-23 18:54:27 +00:00

fonts

…

ID3

…

images

…

js

TinyMCE: check if wp.mce.views exists before loading the wpview plugin. Fixes a js error when the rest of the media scripts are not loaded.

2016-05-30 22:05:27 +00:00

pomo

…

random_compat

…

Requests

HTTP API: Fix compatibility with cURL <7.22

2016-05-13 11:15:29 +00:00

rest-api

Docs: Standardize hook docs in wp-includes/rest-api/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:08:29 +00:00

SimplePie

…

Text

…

theme-compat

Docs: Standardize DocBlock summaries for hooks that serve to "print" something to use third-person singular verbs.

2016-05-25 16:05:27 +00:00

widgets

Docs: Standardize hook docs in wp-includes/widgets/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:06:28 +00:00

admin-bar.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 18:59:27 +00:00

atomlib.php

External Libraries: After [37402], replace two more instances of split() with explode() in wp-includes/atomlib.php.

2016-05-19 00:06:28 +00:00

author-template.php

Docs: Standardize filter docs in wp-includes/author-template.php to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:25:26 +00:00

bookmark-template.php

Docs: Standardize filter docs in wp-includes/bookmark-template.php to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:24:28 +00:00

bookmark.php

Docs: Improve formatting in the DocBlock for sanitize_bookmark_field().

2016-05-27 17:16:27 +00:00

cache.php

Docs: Fix an incorrect Codex link in the file header for wp-includes/cache.php.

2016-05-18 22:07:28 +00:00

canonical.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

capabilities.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

category-template.php

Docs: Improve documentation for wp_generate_tag_cloud() default arguments by formatting them into in a hash-notation.

2016-05-27 18:00:28 +00:00

category.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

class-feed.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

class-http.php

Docs: Standardize filter docs in wp-includes/class-http.php to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:43:27 +00:00

class-IXR.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

class-json.php

…

class-oembed.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

class-phpass.php

…

class-phpmailer.php

…

class-pop3.php

…

class-requests.php

HTTP API: Replace internals with Requests library.

2016-05-13 04:42:28 +00:00

class-simplepie.php

…

class-smtp.php

…

class-snoopy.php

…

class-walker-category-dropdown.php

…

class-walker-category.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

class-walker-comment.php

Comments: pass $comment to comment_text() in Walker_Comment::comment() instead of using a function which can skip the cache.

2016-04-29 15:47:27 +00:00

class-walker-page-dropdown.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

class-walker-page.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

class-wp-admin-bar.php

…

class-wp-ajax-response.php

Docs: Remove/replace invalid inline @link tags in DocBlocks in wp-includes/*.

2016-05-22 17:39:28 +00:00

class-wp-comment-query.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks for core classes.

2016-05-23 18:54:27 +00:00

class-wp-comment.php

…

class-wp-customize-control.php

Docs: Standardize filter docs in the Customizer classes to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:10:29 +00:00

class-wp-customize-manager.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks for core classes.

2016-05-23 18:54:27 +00:00

class-wp-customize-nav-menus.php

Docs: Standardize filter docs in the Customizer classes to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:10:29 +00:00

class-wp-customize-panel.php

Docs: Standardize filter docs in the Customizer classes to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:10:29 +00:00

class-wp-customize-section.php

Docs: Standardize filter docs in the Customizer classes to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:10:29 +00:00

class-wp-customize-setting.php

Docs: Standardize filter docs in the Customizer classes to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:10:29 +00:00

class-wp-customize-widgets.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks for core classes.

2016-05-23 18:54:27 +00:00

class-wp-editor.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-embed.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks for core classes.

2016-05-23 18:54:27 +00:00

class-wp-error.php

Docs: Remove/replace invalid inline @link tags in DocBlocks in wp-includes/*.

2016-05-22 17:39:28 +00:00

class-wp-http-cookie.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-http-curl.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-http-encoding.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-http-ixr-client.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-http-proxy.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-http-requests-response.php

Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.

2016-05-13 18:41:31 +00:00

class-wp-http-response.php

…

class-wp-http-streams.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-image-editor-gd.php

Docs: Ensure hook and duplicate hook docs directly precede all instances of the image_memory_limit filter.

2016-05-30 02:14:30 +00:00

class-wp-image-editor-imagick.php

Docs: Ensure hook and duplicate hook docs directly precede all instances of the image_memory_limit filter.

2016-05-30 02:14:30 +00:00

class-wp-image-editor.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-meta-query.php

In WP_Meta_Query, don't cast meta_value to CHAR.

2016-05-30 04:36:27 +00:00

class-wp-metadata-lazyloader.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks for core classes.

2016-05-23 18:54:27 +00:00

class-wp-network.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-oembed-controller.php

Docs: Add missing @access tags to methods in WP_oEmbed_Controller.

2016-05-25 19:22:27 +00:00

class-wp-post.php

…

class-wp-rewrite.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks for core classes.

2016-05-23 18:54:27 +00:00

class-wp-role.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-roles.php

Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.

2016-05-13 18:41:31 +00:00

class-wp-site-query.php

Multisite: Introduce WP_Site_Query

2016-05-20 22:04:27 +00:00

class-wp-site.php

Multisite: Introduce get_site()

2016-05-20 04:41:27 +00:00

class-wp-tax-query.php

Docs: Remove inline @see tags from function, class, and method references in inline docs.

2016-05-02 04:00:28 +00:00

class-wp-term-query.php

Docs: Link up a reference to the get_terms_args filter in the hook doc for get_terms_defaults.

2016-05-26 15:17:27 +00:00

class-wp-term.php

…

class-wp-theme.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks for core classes.

2016-05-23 18:54:27 +00:00

class-wp-user-query.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-user.php

Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.

2016-05-13 18:41:31 +00:00

class-wp-walker.php

Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.

2016-05-13 18:41:31 +00:00

class-wp-widget-factory.php

Widgets: Provide PHP 5.2 fallback for spl_object_hash() if disabled in logic for registering and unregistering pre-instantiated widgets.

2016-04-30 22:36:28 +00:00

class-wp-widget.php

Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:15:28 +00:00

class-wp-xmlrpc-server.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks for core classes.

2016-05-23 18:54:27 +00:00

class-wp.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 18:59:27 +00:00

class.wp-dependencies.php

…

class.wp-scripts.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

class.wp-styles.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

comment-template.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 18:59:27 +00:00

comment.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 18:59:27 +00:00

compat.php

…

cron.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 18:59:27 +00:00

date.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

default-constants.php

…

default-filters.php

HTTP API: Add browser compatibility hook for 3xx redirects.

2016-05-13 05:11:27 +00:00

default-widgets.php

…

deprecated.php

Docs: Ensure hook and duplicate hook docs directly precede all instances of the image_memory_limit filter.

2016-05-30 02:14:30 +00:00

embed-template.php

…

embed.php

Embeds: Ensure embed widths are integers.

2016-05-24 06:15:28 +00:00

feed-atom-comments.php

…

feed-atom.php

…

feed-rdf.php

…

feed-rss2-comments.php

…

feed-rss2.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

feed-rss.php

…

feed.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:01:27 +00:00

formatting.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:01:27 +00:00

functions.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:01:27 +00:00

functions.wp-scripts.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:01:27 +00:00

functions.wp-styles.php

…

general-template.php

Docs: Standardize DocBlock summaries for hooks that serve to "print" something to use third-person singular verbs.

2016-05-25 16:05:27 +00:00

http.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:01:27 +00:00

kses.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:01:27 +00:00

l10n.php

Docs: Standardize filter docs in wp-includes/l10n.php to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:48:28 +00:00

link-template.php

Docs: Update the return description for get_preview_post_link() to note that it can also return null.

2016-05-25 18:25:28 +00:00

load.php

Bootstrap/Load: Silence ini_set() in wp_debug_mode().

2016-05-17 20:22:28 +00:00

locale.php

Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.

2016-05-13 18:41:31 +00:00

media-template.php

…

media.php

Docs: Standardize DocBlock summaries for hooks that serve to "print" something to use third-person singular verbs.

2016-05-25 16:05:27 +00:00

meta.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

ms-blogs.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

ms-default-constants.php

…

ms-default-filters.php

…

ms-deprecated.php

…

ms-files.php

…

ms-functions.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in wp-includes/ms-functions.php.

2016-05-23 18:56:27 +00:00

ms-load.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

ms-settings.php

Multisite: Wrap the main bootstrap process in a function

2016-05-20 20:57:28 +00:00

nav-menu-template.php

Docs: Correct DocBlock descriptions for the $before, $after, $link_before, and $link_after arguments for wp_nav_menu().

2016-05-25 16:17:27 +00:00

nav-menu.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

option.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00

pluggable-deprecated.php

…

pluggable.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00

plugin.php

Bootstrap/Load: Load plugin.php earlier in wp-settings.php

2016-05-27 19:20:29 +00:00

post-formats.php

…

post-template.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00

post-thumbnail-template.php

Docs: Standardize filter docs in wp-includes/post-thumbnail-template.php to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:29:27 +00:00

post.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00

query.php

Allow term meta lazy-loading to be selectively disabled in WP_Query.

2016-05-28 03:10:29 +00:00

registration-functions.php

…

registration.php

…

rest-api.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00

revision.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00

rewrite.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00

rss-functions.php

…

rss.php

External Libraries: Replace split() with explode() in the deprecated Atom and MagpieRSS files.

2016-05-07 15:59:29 +00:00

script-loader.php

External Libraries: Update jQuery to 1.12.4.

2016-05-23 09:00:29 +00:00

session.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00

shortcodes.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

taxonomy.php

Ensure that get_terms() can accept querystring-style arguments.

2016-05-31 12:54:29 +00:00

template-loader.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

template.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

theme.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00

update.php

Upgrade: Allow update checks on upgrader_process_complete to be run during Ajax requests.

2016-05-25 19:36:28 +00:00

user.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00

vars.php

Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.

2016-05-22 18:50:28 +00:00

version.php

Database: Split the logic of wpdb::init_charset() into a separate method.

2016-06-01 02:38:29 +00:00

widgets.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00

wlwmanifest.xml

…

wp-db.php

Database: Split the logic of wpdb::init_charset() into a separate method.

2016-06-01 02:38:29 +00:00

wp-diff.php

Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.

2016-05-23 19:02:28 +00:00