Boone Gorges f6fb4653eb Don't notify post authors about spam comments. ...

[34106] moved post author notification to a hook, and in the process, missed
the 'spam' check. This changeset restores that check.

To make unit testing easier, the notification callbacks have been refactored
to return values: false when various conditions aren't met (eg, approved
comments should not trigger moderation emails), and the return value of the
`wp_notify_*()` function otherwise.

Props cfinke, kraftbj.
See #33587.
Built from https://develop.svn.wordpress.org/trunk@34250


git-svn-id: http://core.svn.wordpress.org/trunk@34214 1a063a9b-81f0-0310-95a4-ce76da25c4cd

2015-09-16 22:00:25 +00:00

..

certificates

…

css

Update links to the user profile editing screen in the admin toolbar when the current logged in user has no role on the current site. Covers single site and Multisite and introduces tests.

2015-09-14 17:10:26 +00:00

fonts

Dashicons: Fix font ID in SVG file.

2015-07-23 10:03:24 +00:00

ID3

…

images

…

js

Passwords: Trigger a wp-check-valid-field event when the password field is filled with a password by generatePassword().

2015-09-14 10:39:27 +00:00

pomo

…

SimplePie

…

Text

…

theme-compat

After [33961], pass $comment to get_comment_date() where possible to avoid extra cache/db lookups.

2015-09-11 06:15:24 +00:00

widgets

After [33961], pass $comment to get_comment_link() where possible to avoid extra cache/db lookups.

2015-09-11 06:21:25 +00:00

admin-bar.php

Create a function, get_preview_post_link(), to DRY the logic for applying the 'preview_post_link' filter to a URL.

2015-09-15 04:15:25 +00:00

atomlib.php

…

author-template.php

…

bookmark-template.php

…

bookmark.php

After [33843], update the location of some files in This filter is documented in docs

2015-09-08 22:17:26 +00:00

cache.php

Docs: Improve documentation for the WP_Object_Cache class.

2015-09-16 10:03:26 +00:00

canonical.php

Implement wp_login_url() and wp_registration_url() in places where wp-login.php is currently hard-coded.

2015-09-15 17:11:35 +00:00

capabilities-functions.php

Docs: Add documentation for $object_id, the optional second parameter in current_user_can() and WP_User::has_cap(), and the optional third parameter in map_meta_cap().

2015-09-16 07:36:32 +00:00

capabilities.php

Roles: move classes into their own file. capbilities.php loads the new files, so this is 100% BC if someone is loading capbilities.php directly. New files created using svn cp.

2015-08-26 04:58:21 +00:00

category-functions.php

Move Walker_Category and Walker_CategoryDropdown into their own files via svn cp. Remove them from category-template.php. Load them in category.php. svn cp category.php over to category-functions.php, which also loads now in category.php.

2015-09-14 03:10:24 +00:00

category-template.php

Move Walker_Category and Walker_CategoryDropdown into their own files via svn cp. Remove them from category-template.php. Load them in category.php. svn cp category.php over to category-functions.php, which also loads now in category.php.

2015-09-14 03:10:24 +00:00

category.php

Move Walker_Category and Walker_CategoryDropdown into their own files via svn cp. Remove them from category-template.php. Load them in category.php. svn cp category.php over to category-functions.php, which also loads now in category.php.

2015-09-14 03:10:24 +00:00

class-feed.php

…

class-http.php

Place the filter docblock for http_api_transports immediately above the filter.

2015-09-15 08:12:25 +00:00

class-IXR.php

…

class-json.php

Docs: Put "it's" in its place (again).

2015-09-16 12:46:28 +00:00

class-oembed.php

Space out.

2015-08-31 21:25:21 +00:00

class-phpass.php

…

class-phpmailer.php

…

class-pop3.php

Docs: Put "it's" in its place (again).

2015-09-16 12:46:28 +00:00

class-simplepie.php

…

class-smtp.php

…

class-snoopy.php

After [33843], update the location of some files in This filter is documented in docs

2015-09-08 22:17:26 +00:00

class-walker-category-dropdown.php

Move Walker_Category and Walker_CategoryDropdown into their own files via svn cp. Remove them from category-template.php. Load them in category.php. svn cp category.php over to category-functions.php, which also loads now in category.php.

2015-09-14 03:10:24 +00:00

class-walker-category.php

Move Walker_Category and Walker_CategoryDropdown into their own files via svn cp. Remove them from category-template.php. Load them in category.php. svn cp category.php over to category-functions.php, which also loads now in category.php.

2015-09-14 03:10:24 +00:00

class-walker-comment.php

After [33961], pass $comment to get_comment_link() where possible to avoid extra cache/db lookups.

2015-09-11 06:21:25 +00:00

class-walker-page-dropdown.php

Move Walker_Page and Walker_PageDropdown into their own files via svn cp. Remove them from post-template.php. Load them in post.php.

2015-09-14 02:59:24 +00:00

class-walker-page.php

Move Walker_Page and Walker_PageDropdown into their own files via svn cp. Remove them from post-template.php. Load them in post.php.

2015-09-14 02:59:24 +00:00

class-wp-admin-bar.php

…

class-wp-ajax-response.php

…

class-wp-comment-query.php

WP_Comment_Query: add comment__in to allowed values for $orderby.

2015-09-15 16:35:44 +00:00

class-wp-comment.php

Docs: Add complete file, class, property, and method documentation for the new WP_Comment class, introduced in [33891].

2015-09-03 19:58:24 +00:00

class-wp-customize-control.php

foreach is a statement, not a function.

2015-08-25 20:28:22 +00:00

class-wp-customize-manager.php

Add a comment to strings where the ellipsis cannot be used due to json_encode(), placeholders, or external dependencies.

2015-09-16 11:59:26 +00:00

class-wp-customize-nav-menus.php

Customizer: Use existing decoupled strings in Menu Locations section. See [31941] and [31951].

2015-08-25 21:53:20 +00:00

class-wp-customize-panel.php

Customize: Remove redundant aria-label attributes.

2015-09-13 06:16:26 +00:00

class-wp-customize-section.php

Round 2 of: We should use ellipses … / … instead of three dots/periods ... e.g Loading… not Loading...

2015-09-09 04:39:25 +00:00

class-wp-customize-setting.php

Add Customizer docs.

2015-09-05 19:53:24 +00:00

class-wp-customize-widgets.php

Customizer: Use hash_equals() for widgets.

2015-08-04 04:51:50 +00:00

class-wp-editor.php

Add a comment to strings where the ellipsis cannot be used due to json_encode(), placeholders, or external dependencies.

2015-09-16 11:59:26 +00:00

class-wp-embed.php

foreach is a statement, not a function.

2015-08-25 20:28:22 +00:00

class-wp-error.php

…

class-wp-http-cookie.php

Docs: Add a missing file header to wp-includes/class-wp-http-cookie.php, introduced in [33748].

2015-09-03 03:19:21 +00:00

class-wp-http-curl.php

After [33843], update the location of some files in This filter is documented in docs

2015-09-08 22:17:26 +00:00

class-wp-http-encoding.php

Docs: Add a missing file header for wp-includes/class-wp-http-encoding.php, introduced in [33748].

2015-09-03 03:28:21 +00:00

class-wp-http-ixr-client.php

Docs: Update the hook doc summary for the wp_http_ixr_client_headers filter, introduced in [34164].

2015-09-15 16:16:43 +00:00

class-wp-http-proxy.php

Docs: Add a missing file header to wp-includes/class-wp-http-proxy.php, introduced in [33748].

2015-09-03 03:30:21 +00:00

class-wp-http-streams.php

Docs: Put "it's" in its place (again).

2015-09-16 12:46:28 +00:00

class-wp-image-editor-gd.php

…

class-wp-image-editor-imagick.php

…

class-wp-image-editor.php

foreach is a statement, not a function.

2015-08-25 20:28:22 +00:00

class-wp-meta-query.php

Use stricter sanitization for meta query clause keys.

2015-09-12 21:06:24 +00:00

class-wp-network.php

Multisite: Implement the get_by_path method in WP_Network.

2015-09-13 23:40:24 +00:00

class-wp-post.php

Posts: move WP_Post into its own file. post.php loads the new files, so this is 100% BC if someone is loading post.php directly. New files created using svn cp.

2015-08-26 12:40:21 +00:00

class-wp-rewrite.php

Rewrite: move WP_Rewrite into its own file. rewrite.php loads the new files, so this is 100% BC if someone is loading rewrite.php directly. New files created using svn cp.

2015-08-26 04:42:20 +00:00

class-wp-role.php

Roles: move classes into their own file. capbilities.php loads the new files, so this is 100% BC if someone is loading capbilities.php directly. New files created using svn cp.

2015-08-26 04:58:21 +00:00

class-wp-roles.php

Ensure that role is not empty before adding it in add_role() function and methods.

2015-09-09 03:42:25 +00:00

class-wp-tax-query.php

Taxonomy: move WP_Tax_Query into its own file. taxonomy.php loads the new files, so this is 100% BC if someone is loading taxonomy.php directly. New files created using svn cp.

2015-08-26 12:49:21 +00:00

class-wp-theme.php

Docs: Fix some syntactical issues with the DocBlock for the WP_Theme->update property, introduced in [33957].

2015-09-16 13:29:25 +00:00

class-wp-user-query.php

Docs: Add a missing file header for wp-includes/class-wp-user-query.php, introduced in [33749].

2015-09-04 01:26:25 +00:00

class-wp-user.php

Docs: Add documentation for $object_id, the optional second parameter in current_user_can() and WP_User::has_cap(), and the optional third parameter in map_meta_cap().

2015-09-16 07:36:32 +00:00

class-wp-walker.php

Docs: Add missing parameter and return descriptions for Walker::get_number_of_root_elements().

2015-09-14 15:33:27 +00:00

class-wp-widget-factory.php

Docs: Clarify the file header summary for class-wp-widget-factory.php, introduced in [33746].

2015-09-03 02:54:22 +00:00

class-wp-widget.php

Docs: Improve the file header for class-wp-widget.php to describe what the file contains.

2015-09-03 02:50:21 +00:00

class-wp-xmlrpc-server.php

XMLRPC: Don't allow private posts to be sticky.

2015-09-14 22:38:23 +00:00

class-wp.php

Allow taxonomies to be non-public.

2015-09-16 19:05:23 +00:00

class.wp-dependencies.php

foreach is a statement, not a function.

2015-08-25 20:28:22 +00:00

class.wp-scripts.php

…

class.wp-styles.php

…

comment-functions.php

Don't notify post authors about spam comments.

2015-09-16 22:00:25 +00:00

comment-template.php

Revert [33925], by-reference array manipulation is breaking comments in some themes.

2015-09-16 18:14:25 +00:00

comment.php

Walker_Comment should be in its own file. Loaded now via wp-includes/comment.php, which makes it 100% BC.

2015-09-09 02:41:24 +00:00

compat.php

…

cron.php

Document @return value for wp_unschedule_event().

2015-09-11 11:35:24 +00:00

date.php

Simplify the weeks-per-year calculation WP_Date_Query::validate_date_values().

2015-08-29 01:47:21 +00:00

default-constants.php

After [33698], wrap the time constants in a DocBlock template.

2015-08-25 21:21:21 +00:00

default-filters.php

Add the site icon meta tags to wp-login.php.

2015-09-14 18:02:24 +00:00

default-widgets.php

Move widget classes to their own files in wp-includes/widgets:

2015-09-01 13:49:21 +00:00

deprecated.php

Deprecate wp_get_http() - function isn't used anywhere (apart from itself).

2015-09-09 04:26:25 +00:00

feed-atom-comments.php

…

feed-atom.php

…

feed-rdf.php

…

feed-rss2-comments.php

…

feed-rss2.php

…

feed-rss.php

…

feed.php

Docs: Make a minor adjustment to the description syntax for the optional $comment argument in the DocBlock for comment_link(), introduced in [34071].

2015-09-16 11:02:24 +00:00

formatting.php

Fix a typo in wptexturize() and wp_replace_in_html_tags() comments.

2015-09-16 05:54:26 +00:00

functions.php

More comment functions can accept a full object instead of comment_ID to reduce cache/db lookups.

2015-09-14 21:40:24 +00:00

functions.wp-scripts.php

…

functions.wp-styles.php

…

general-template.php

Implement wp_login_url() and wp_registration_url() in places where wp-login.php is currently hard-coded.

2015-09-15 17:11:35 +00:00

http-functions.php

Docs: Clarify the file header summary for wp-includes/http-functions.php, introduced in [33748].

2015-09-03 03:37:20 +00:00

http.php

Docs: Add inline DocBlocks for the require_once() calls that now bring in top-level HTTP API functionality and HTTP API classes.

2015-09-03 04:36:30 +00:00

kses.php

Allow these CSS properties in KSES: min-height', 'max-height', 'min-width', 'max-width'

2015-08-25 21:46:20 +00:00

l10n.php

foreach is a statement, not a function.

2015-08-25 20:28:22 +00:00

link-template.php

Remove the ability to view the post listing screen and post editing screen for post types with show_ui set to false. It is unexpected and unintended behaviour that this is allowed.

2015-09-15 10:27:29 +00:00

load.php

Favicon: Do not specify a Content-Length: 0 header for our "empty" response to fail more gracefully on environments with extra whitespace on output.

2015-09-07 02:18:26 +00:00

locale.php

Use _x() instead of string hacks for weekday and month abbreviations.

2015-09-11 15:36:25 +00:00

media-template.php

After [34048], restore the else statement for h (height of video) in wp_underscore_video_template().

2015-09-11 18:30:26 +00:00

media.php

Don't ever use the guid value when retrieving URLs for media, use wp_get_attachment_url(). Use get_attached_file() for path to file.

2015-09-15 02:50:25 +00:00

meta-functions.php

After [33843], update the location of some files in This filter is documented in docs

2015-09-08 22:17:26 +00:00

meta.php

Meta: move WP_Meta_Query into its own file. meta.php loads the new files, so this is 100% BC if someone is loading meta.php directly. New files created using svn cp.

2015-08-26 13:02:21 +00:00

ms-blogs.php

…

ms-default-constants.php

…

ms-default-filters.php

Send multisite site/user signup emails via hooked functions.

2015-09-14 03:28:24 +00:00

ms-deprecated.php

Docs: Standardize @deprecated tag formatting and add missing summaries to deprecated functions in wp-includes/ms-deprecated.php.

2015-08-20 22:36:25 +00:00

ms-files.php

…

ms-functions.php

Docs: Add a changelog entry for the addition of 'wp-admin', 'wp-content', and 'wp-includes' as reserved names for the subdirectory_reserved_names filter docs.

2015-09-16 13:26:26 +00:00

ms-load.php

Multisite: Implement the get_by_path method in WP_Network.

2015-09-13 23:40:24 +00:00

ms-settings.php

Multisite: Implement the get_by_path method in WP_Network.

2015-09-13 23:40:24 +00:00

nav-menu-template.php

Avoid PHP notices in redirect_canonical() and _wp_menu_item_classes_by_context() if $_SERVER['HTTP_HOST'] is not set.

2015-08-28 03:31:20 +00:00

nav-menu.php

foreach is a statement, not a function.

2015-08-25 20:28:22 +00:00

option.php

Update the length limit in set_transient() docs after [34030].

2015-09-11 15:10:27 +00:00

pluggable-deprecated.php

Docs: Standardize @deprecated tag formatting for deprecated functions in wp-includes/pluggable-deprecated.php.

2015-08-20 22:15:25 +00:00

pluggable.php

After [34160], also upgrade objects passed to get_avatar().

2015-09-16 17:34:24 +00:00

plugin.php

foreach is a statement, not a function.

2015-08-25 20:28:22 +00:00

post-formats.php

foreach is a statement, not a function.

2015-08-25 20:28:22 +00:00

post-functions.php

Throw a notice when an invalid tax is passed to wp_insert_post().

2015-09-16 19:25:26 +00:00

post-template.php

Docs: Update the DocBlock for wp_page_menu() to include 'before', 'after', and 'walker' arguments added in [34200].

2015-09-16 16:47:25 +00:00

post-thumbnail-template.php

Update post thumbnail functions to allow a WP_Post to be passed.

2015-09-15 03:46:25 +00:00

post.php

Move Walker_Page and Walker_PageDropdown into their own files via svn cp. Remove them from post-template.php. Load them in post.php.

2015-09-14 02:59:24 +00:00

query.php

Revert [33925], by-reference array manipulation is breaking comments in some themes.

2015-09-16 18:14:25 +00:00

registration-functions.php

…

registration.php

…

revision.php

foreach is a statement, not a function.

2015-08-25 20:28:22 +00:00

rewrite-constants.php

Docs: Clarify the file header summary for wp-includes/rewrite-constants.php, introduced in [33751].

2015-09-04 01:52:24 +00:00

rewrite-functions.php

Rewrite: move WP_Rewrite into its own file. rewrite.php loads the new files, so this is 100% BC if someone is loading rewrite.php directly. New files created using svn cp.

2015-08-26 04:42:20 +00:00

rewrite.php

Rewrite: move WP_Rewrite into its own file. rewrite.php loads the new files, so this is 100% BC if someone is loading rewrite.php directly. New files created using svn cp.

2015-08-26 04:42:20 +00:00

rss-functions.php

…

rss.php

foreach is a statement, not a function.

2015-08-25 20:28:22 +00:00

script-loader.php

Add a comment to strings where the ellipsis cannot be used due to json_encode(), placeholders, or external dependencies.

2015-09-16 11:59:26 +00:00

session.php

…

shortcodes.php

Shortcodes: don't allow unclosed HTML elements in attributes

2015-09-14 22:36:24 +00:00

taxonomy-functions.php

Allow taxonomies to be non-public.

2015-09-16 19:05:23 +00:00

taxonomy.php

Taxonomy: move WP_Tax_Query into its own file. taxonomy.php loads the new files, so this is 100% BC if someone is loading taxonomy.php directly. New files created using svn cp.

2015-08-26 12:49:21 +00:00

template-loader.php

…

template.php

…

theme.php

Flush rewrite rules upon theme switch

2015-09-10 23:50:24 +00:00

update.php

…

user-functions.php

Improve validation of user_login and user_nicename length.

2015-09-15 22:14:26 +00:00

user.php

Docs: Clarify the file header summary for wp-includes/user.php, the top-level file for the core Users API.

2015-09-04 01:33:24 +00:00

vars.php

Introduce a new $is_edge global for the Microsoft Edge browser.

2015-09-05 22:33:23 +00:00

version.php

Don't notify post authors about spam comments.

2015-09-16 22:00:25 +00:00

widget-functions.php

After [33843], update the location of some files in This filter is documented in docs

2015-09-08 22:17:26 +00:00

widgets.php

Docs: Clarify the file header summary for wp-includes/widgets.php, the top-level file for the core Widgets API.

2015-09-03 03:14:20 +00:00

wlwmanifest.xml

…

wp-db.php

Docs: Put "it's" in its place (again).

2015-09-16 12:46:28 +00:00

wp-diff.php

…