Includes:
* Standardizing on the `bool` type for the `$gmt` parameter between `current_time()` and `date_i18n()`.
* Documenting `null` as an acceptable value for `$timestamp` and `$timezone` parameters in `wp_date()`.
* Removing a redundant note on the `$gmt` parameter for the `date_i18n` filter, as defaults are normally only documented for function parameters.
Follow-up to [1001], [9616], [28109], [45901].
Props dilipbheda.
Fixes#63207.
Built from https://develop.svn.wordpress.org/trunk@60119
git-svn-id: http://core.svn.wordpress.org/trunk@59455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This is a follow-up to [60038], which updates the PHPUnit tests to account for different systems producing potentially different hashes due to platform specific floating point precision settings.
Props debarghyabanerjee, joemcgill, peterwilsoncc, siliconforks.
Fixes#63175.
Built from https://develop.svn.wordpress.org/trunk@60113
git-svn-id: http://core.svn.wordpress.org/trunk@59449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Per the [https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#6-file-headers documentation standards], whenever possible, all WordPress files should contain a header DocBlock, regardless of the file’s contents – this includes files containing classes.
However, this recommendation makes less sense for unit test classes if not applied consistently, and the duplicate tags cause some confusion.
This commit aims to reduce confusion and avoid repeating information by combining the DocBlocks.
Includes using third-person singular verbs in test method descriptions, as per the documentation standards.
Follow-up to [55337], [60108], [60109].
See #63166.
Built from https://develop.svn.wordpress.org/trunk@60112
git-svn-id: http://core.svn.wordpress.org/trunk@59448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset updates the Quote Blocks HTML markup of the default sample page, to avoid unecessary migration (and the related console information) when loading its content in the editor.
Props wildworks, abcd95, audrasjb, ankitkumarshah.
Fixes#63176.
Built from https://develop.svn.wordpress.org/trunk@60111
git-svn-id: http://core.svn.wordpress.org/trunk@59447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This expands the pull request cleanup action to also account for the `Core-{n}` pattern. This pattern dynamically links to Trac tickets without having to explicitly provide the ticket URL and are not detected in the current workflow logic.
Props yogeshbhutkar, johnbillion.
Fixes#63081.
Built from https://develop.svn.wordpress.org/trunk@60110
git-svn-id: http://core.svn.wordpress.org/trunk@59446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset fixes an issue where `wp_get_canonical_url()` always returned `false` for attachments. Attachments have a `inherit` post status rather than `publish`. The `wp_get_canonical_url()` function was directly checking `$post->post_status === 'publish'`, causing it to always return `false` for attachments. Using `get_post_status()` fixes the issue as if the post is an attachment, then the parent post status will be given instead.
Follow-up to [37685].
Props othernoel, ankitkumarshah, SirLouen,
Fixes#63041.
Built from https://develop.svn.wordpress.org/trunk@60108
git-svn-id: http://core.svn.wordpress.org/trunk@59444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When using a non-direct filesystem, the call in `WP_Upgrader::maintenance_mode()` did not include the required credentials, leading to a fatal error as the connection was not initialized properly.
This commit attempts to use the stored credentials if available, and triggers a notice otherwise.
Follow-up to [56341], [58128].
Props SirLouen, hideishi, dd32, tusharaddweb, takuword, SergeyBiryukov.
Fixes#62718.
Built from https://develop.svn.wordpress.org/trunk@60107
git-svn-id: http://core.svn.wordpress.org/trunk@59443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Because 6.8 is not yet officially released, `6.8` cannot be used in a test matrix.
This removes 6.8 from the Upgrade Testing workflow and changes the value used for the Upgrade Develop Version Testing workflow to `6.8-RC1` to confirm that updating from `6.8-RC1` to `trunk` (which is now `6.9-alpha`) is successful.
Follow-up to [60093].
Props mukesh27.
See #63164.
Built from https://develop.svn.wordpress.org/trunk@60097
git-svn-id: http://core.svn.wordpress.org/trunk@59433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Introducing the new content for the 6.8 About page. This release introduces a new header image, but otherwise only minor tweaks to the layout and colors.
See #63025.
Props michelleames, marybaum, jeffpaul, flixos90, krupajnanda, vgnavada, karmatosed, benjamin_zekavica, ryelle, peterwilsoncc, benniledl, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@60087
git-svn-id: http://core.svn.wordpress.org/trunk@59423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Normalize behavior between uploading in the media library and uploading directly to the block editor. Now, when uploading an image with a mime type the server does not support (either in the media library or the block editor), the user will see an error message “This image cannot be processed by the web server. Convert it to JPEG or PNG before uploading”.
Alos, add a new filter `wp_prevent_unsupported_mime_type_uploads` which determines whether the server should prevent uploads for image types it doesn't support. The default value is true and the filter also receives the uploaded image mime type.
Props: joomskys, adamsilverstein, azaozz, swissspidy, joemcgill, flixos90, audrasjb.
Fixes#61167
Built from https://develop.svn.wordpress.org/trunk@60084
git-svn-id: http://core.svn.wordpress.org/trunk@59420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the following GitHub Actions:
- `actions/upload-artifact` from `4.6.1` to `4.6.2`
- `actions/download-artifact` from `4.1.9` to `4.2.1`
- `actions/cache` from `4.2.2` to `4.2.3`
Though these are minor updates, they include a hardening change, switching to masking cache entry tokens in debug logs.
Fixes#62221.
Built from https://develop.svn.wordpress.org/trunk@60083
git-svn-id: http://core.svn.wordpress.org/trunk@59419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Currently, workflows are configured to only run for `wordpress-develop` or when pull requests are opened where forks and mirrors are the base repository.
Because a Dependabot configuration is present in the repository, it cannot be turned off for mirrors. This results in workflows running for all Dependabot PRs, which is problematic for private mirrors and needlessly consumes minutes and resources.
Props swissspidy, johnbillion.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@60080
git-svn-id: http://core.svn.wordpress.org/trunk@59416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset introduces a modification to the `get_params()` method within the WordPress REST API. The change ensures that the `rest_route` parameter is excluded from the parameters returned when pretty permalinks are not enabled. This update enhances the developer experience by ensuring that the parameters returned by `get_params()` are relevant and do not include unnecessary values, thereby reducing potential confusion and errors.
Props westonruter, TimothyBlynJacobs, audrasjb, debarghyabanerjee, dilip2615, shanemuir, peterwilsoncc.
Fixes#62163.
Built from https://develop.svn.wordpress.org/trunk@60073
git-svn-id: http://core.svn.wordpress.org/trunk@59409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This adds white space only changes made during 6.8 to the list of commits which we instruct git blame to ignore. Excluding them helps to reduce the noise when doing code archaeology.
Follow-up to [53007].
Props jorbin, peterwilsoncc.
See #62279.
Built from https://develop.svn.wordpress.org/trunk@60071
git-svn-id: http://core.svn.wordpress.org/trunk@59407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This adds the same logic to filter directive data attributes to ignore invalid data attributes that is applied in the client to avoid processing directives on the server that will not be processed in the client.
Props jonsurrell, SirLouen.
Fixes#62426.
Built from https://develop.svn.wordpress.org/trunk@60070
git-svn-id: http://core.svn.wordpress.org/trunk@59406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that not only the return values match the expected results, but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.
Follow-up to [48291], [50124], [57603].
See #62278.
Built from https://develop.svn.wordpress.org/trunk@60068
git-svn-id: http://core.svn.wordpress.org/trunk@59404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that not only the return values match the expected results, but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.
Follow-up to [39061], [48937].
See #62278.
Built from https://develop.svn.wordpress.org/trunk@60067
git-svn-id: http://core.svn.wordpress.org/trunk@59403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This expands the use of Dependabot to also manage npm dependencies by configuring several groups of related packages. After [59983], pull requests for the majority of these updates can now be staged without encountering test failures.
Props joemcgill, peterwilsoncc, swissspidy, johnbillion.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@60066
git-svn-id: http://core.svn.wordpress.org/trunk@59402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
