Fixes a PHP Warning for an undefined array key "QUERY_STRING" in `_wp_get_site_editor_redirection_url()` in some PHP configurations.
Depending on the configuration, `$_SERVER['QUERY_STRING']` can either be unset or an empty string when no query string included in the URL. This changes the condition from a falsey check to an `empty()` check.
Reviewed by Mamaduka.
Merges [60134] to the 6.8 branch.
Props akshaydhere, dilipbheda, johnbillion, rainynewt, sabernhardt, sainathpoojary, shovan_jaya, tusharaddweb, wildworks.
Fixes#63224.
Built from https://develop.svn.wordpress.org/branches/6.8@60135
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Corrects the type for the `$time` and `$previous_time` parameters in the filter to indicate the times are expressed as strings. The values are generated from a call to `microtime()` which returns the time as a string in the form `msec sec`.
Reviewed by audrasjb.
Merges [60128] to the 6.8 branch.
Props tillkruess, westonruter.
Fixes#63194.
Built from https://develop.svn.wordpress.org/branches/6.8@60133
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
These tests are not critical to the bcrypt functionality, they exist to reaffirm that the underlying use of `password_hash()` and `password_verify()` supports this algorithm. The Argon2 tests therefore shouldn't unnecessarily fail on hosts that don't support it.
Reviewed by desrosj.
Merges [60124] to the 6.8 branch.
Props desrosj, johnbillion.
Fixes#21022.
Built from https://develop.svn.wordpress.org/branches/6.8@60126
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Application passwords that aren't hashed using BLAKE2b should be checked using wp_check_password() rather than assuming they were hashed with phpass. This provides full back compat support for application passwords that were created via an overridden wp_hash_password() function that uses an alternative hashing algorithm.
Reviewed by audrasjb.
Merges [60123] into the 6.8 branch.
Props snicco, debarghyabanerjee, peterwilsoncc, jorbin, johnbillion.
Fixes#63203
Built from https://develop.svn.wordpress.org/branches/6.8@60125
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This is a follow-up to [60038], which updates the PHPUnit tests to account for different systems producing potentially different hashes due to platform specific floating point precision settings.
Reviewed by audrasjb, desrosj.
Merges [60113] to the 6.8 branch.
Props debarghyabanerjee, joemcgill, peterwilsoncc, siliconforks.
Fixes#63175.
Built from https://develop.svn.wordpress.org/branches/6.8@60116
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This makes some post-branching changes to the 6.8 branch:
- Pins the most newest supported version of PHP for the local Docker environment
- Switches to using remote references for GitHub Action workflows
- Removes GitHub Action workflow files that will never run from this branch.
See #63164.
Built from https://develop.svn.wordpress.org/branches/6.8@60092
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Introducing the new content for the 6.8 About page. This release introduces a new header image, but otherwise only minor tweaks to the layout and colors.
See #63025.
Props michelleames, marybaum, jeffpaul, flixos90, krupajnanda, vgnavada, karmatosed, benjamin_zekavica, ryelle, peterwilsoncc, benniledl, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@60087
git-svn-id: http://core.svn.wordpress.org/trunk@59423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Normalize behavior between uploading in the media library and uploading directly to the block editor. Now, when uploading an image with a mime type the server does not support (either in the media library or the block editor), the user will see an error message “This image cannot be processed by the web server. Convert it to JPEG or PNG before uploading”.
Alos, add a new filter `wp_prevent_unsupported_mime_type_uploads` which determines whether the server should prevent uploads for image types it doesn't support. The default value is true and the filter also receives the uploaded image mime type.
Props: joomskys, adamsilverstein, azaozz, swissspidy, joemcgill, flixos90, audrasjb.
Fixes#61167
Built from https://develop.svn.wordpress.org/trunk@60084
git-svn-id: http://core.svn.wordpress.org/trunk@59420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the following GitHub Actions:
- `actions/upload-artifact` from `4.6.1` to `4.6.2`
- `actions/download-artifact` from `4.1.9` to `4.2.1`
- `actions/cache` from `4.2.2` to `4.2.3`
Though these are minor updates, they include a hardening change, switching to masking cache entry tokens in debug logs.
Fixes#62221.
Built from https://develop.svn.wordpress.org/trunk@60083
git-svn-id: http://core.svn.wordpress.org/trunk@59419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Currently, workflows are configured to only run for `wordpress-develop` or when pull requests are opened where forks and mirrors are the base repository.
Because a Dependabot configuration is present in the repository, it cannot be turned off for mirrors. This results in workflows running for all Dependabot PRs, which is problematic for private mirrors and needlessly consumes minutes and resources.
Props swissspidy, johnbillion.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@60080
git-svn-id: http://core.svn.wordpress.org/trunk@59416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset introduces a modification to the `get_params()` method within the WordPress REST API. The change ensures that the `rest_route` parameter is excluded from the parameters returned when pretty permalinks are not enabled. This update enhances the developer experience by ensuring that the parameters returned by `get_params()` are relevant and do not include unnecessary values, thereby reducing potential confusion and errors.
Props westonruter, TimothyBlynJacobs, audrasjb, debarghyabanerjee, dilip2615, shanemuir, peterwilsoncc.
Fixes#62163.
Built from https://develop.svn.wordpress.org/trunk@60073
git-svn-id: http://core.svn.wordpress.org/trunk@59409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This adds white space only changes made during 6.8 to the list of commits which we instruct git blame to ignore. Excluding them helps to reduce the noise when doing code archaeology.
Follow-up to [53007].
Props jorbin, peterwilsoncc.
See #62279.
Built from https://develop.svn.wordpress.org/trunk@60071
git-svn-id: http://core.svn.wordpress.org/trunk@59407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This adds the same logic to filter directive data attributes to ignore invalid data attributes that is applied in the client to avoid processing directives on the server that will not be processed in the client.
Props jonsurrell, SirLouen.
Fixes#62426.
Built from https://develop.svn.wordpress.org/trunk@60070
git-svn-id: http://core.svn.wordpress.org/trunk@59406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that not only the return values match the expected results, but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.
Follow-up to [48291], [50124], [57603].
See #62278.
Built from https://develop.svn.wordpress.org/trunk@60068
git-svn-id: http://core.svn.wordpress.org/trunk@59404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that not only the return values match the expected results, but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.
Follow-up to [39061], [48937].
See #62278.
Built from https://develop.svn.wordpress.org/trunk@60067
git-svn-id: http://core.svn.wordpress.org/trunk@59403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This expands the use of Dependabot to also manage npm dependencies by configuring several groups of related packages. After [59983], pull requests for the majority of these updates can now be staged without encountering test failures.
Props joemcgill, peterwilsoncc, swissspidy, johnbillion.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@60066
git-svn-id: http://core.svn.wordpress.org/trunk@59402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset fixes a edge case in `get_custom_logo()` where a page was set for the homepage without any front page in Settings > Reading and the `aria-current` attribute wasn't present on the logo link.
Props bschneidewind, audrasjb, siliconforks, sabernhardt, faisal03, shailu25, peterwilsoncc.
Fixes#62879.
Built from https://develop.svn.wordpress.org/trunk@60062
git-svn-id: http://core.svn.wordpress.org/trunk@59398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fix a PHP warning when opening a page directly in the site editor, eg by navigating to the URL `/wp-admin/site-editor.php?p=%2Fpage&postId=200`, caused by an undefined variable name.
Props abcd95, joemcgill, narenin, soyebsalar, websiteredev, wildworks.
Fixes#63122.
Built from https://develop.svn.wordpress.org/trunk@60061
git-svn-id: http://core.svn.wordpress.org/trunk@59397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This aims to facilitate setting up Xdebug locally without editing the `tools/local-env/php-config.ini` file, which is not ignored by Git by default.
Note that this does not enable Xdebug by default, since both `LOCAL_PHP_XDEBUG=true` and `LOCAL_PHP_XDEBUG_MODE=debug` are additionally required for Xdebug to work.
Props SirLouen, jules-colle, johnbillion, pento.
Fixes#49953.
Built from https://develop.svn.wordpress.org/trunk@60060
git-svn-id: http://core.svn.wordpress.org/trunk@59396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset removes the automatic addition of `rel="noopener"` from links targeting a new tab via `target="_blank"` in the `wp_list_bookmarks()` function. Since this was introduced, supported browsers have changed their security policies and no longer allow the opened link to have JavaScript access to the previous tab. This also removes the unit test cases previously located in `wpListBookmarks.php` as they were dedicated to test the presence of `rel="noopener"`.
Follow-up to [52061], [59120].
Props audrasjb, rvouill, marineevain, jeremy80.
Fixes#63096.
Built from https://develop.svn.wordpress.org/trunk@60058
git-svn-id: http://core.svn.wordpress.org/trunk@59394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This aims to facilitate setting up Xdebug locally without editing the `tools/local-env/php-config.ini` file, which is not ignored by Git by default.
Note that this does not enable Xdebug by default, since both `LOCAL_PHP_XDEBUG=true` and `LOCAL_PHP_XDEBUG_MODE=debug` are additionally required for Xdebug to work.
Props SirLouen, jules-colle, johnbillion, pento.
Fixes#49953.
Built from https://develop.svn.wordpress.org/trunk@60056
git-svn-id: http://core.svn.wordpress.org/trunk@59392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
