Fixes a PHP Warning for an undefined array key "QUERY_STRING" in `_wp_get_site_editor_redirection_url()` in some PHP configurations.
Depending on the configuration, `$_SERVER['QUERY_STRING']` can either be unset or an empty string when no query string included in the URL. This changes the condition from a falsey check to an `empty()` check.
Reviewed by Mamaduka.
Merges [60134] to the 6.8 branch.
Props akshaydhere, dilipbheda, johnbillion, rainynewt, sabernhardt, sainathpoojary, shovan_jaya, tusharaddweb, wildworks.
Fixes#63224.
Built from https://develop.svn.wordpress.org/branches/6.8@60135
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Introducing the new content for the 6.8 About page. This release introduces a new header image, but otherwise only minor tweaks to the layout and colors.
See #63025.
Props michelleames, marybaum, jeffpaul, flixos90, krupajnanda, vgnavada, karmatosed, benjamin_zekavica, ryelle, peterwilsoncc, benniledl, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@60087
git-svn-id: http://core.svn.wordpress.org/trunk@59423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Normalize behavior between uploading in the media library and uploading directly to the block editor. Now, when uploading an image with a mime type the server does not support (either in the media library or the block editor), the user will see an error message “This image cannot be processed by the web server. Convert it to JPEG or PNG before uploading”.
Alos, add a new filter `wp_prevent_unsupported_mime_type_uploads` which determines whether the server should prevent uploads for image types it doesn't support. The default value is true and the filter also receives the uploaded image mime type.
Props: joomskys, adamsilverstein, azaozz, swissspidy, joemcgill, flixos90, audrasjb.
Fixes#61167
Built from https://develop.svn.wordpress.org/trunk@60084
git-svn-id: http://core.svn.wordpress.org/trunk@59420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fix a PHP warning when opening a page directly in the site editor, eg by navigating to the URL `/wp-admin/site-editor.php?p=%2Fpage&postId=200`, caused by an undefined variable name.
Props abcd95, joemcgill, narenin, soyebsalar, websiteredev, wildworks.
Fixes#63122.
Built from https://develop.svn.wordpress.org/trunk@60061
git-svn-id: http://core.svn.wordpress.org/trunk@59397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Since `ABSPATH` is defined and documented to end with a forward slash `/`, this changeset removes the first `/` from strings appended to `ABSPATH` in various files, leading to `//` in the resulting path.
Follow-up to [54872], [55720], [57545].
Props dhruvik18, SergeyBiryukov.
Fixes#63102.
Built from https://develop.svn.wordpress.org/trunk@60034
git-svn-id: http://core.svn.wordpress.org/trunk@59370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
If the author display name is unknown, show an `emdash` and screen reader text `(no author)`, consistent with other cases where information is unknown. Fix an issue where an unknown author name displayed as an invisible link with no text.
Props kkmuffme, hdkothari81, shailu25, snehapatil02, sabernhardt, faisal03, rishavdutta, sumitbagthariya16, joedolson.
Fixes#62913.
Built from https://develop.svn.wordpress.org/trunk@60032
git-svn-id: http://core.svn.wordpress.org/trunk@59368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Adjust the position of the skip link in viewports between 600 and 782 pixels, where they were hidden due to `overflow-y: auto` in the block editor. Ensures that the skip link is visibly available for users on all viewport sizes.
Props sabernhardt, narenin, audrasjb, mukesh27, joedolson, wildworks.
Fixes#63084.
Built from https://develop.svn.wordpress.org/trunk@59992
git-svn-id: http://core.svn.wordpress.org/trunk@59334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Several significant animations in the customizer did not respect prefers reduced motion. Change CSS to wrap animations in `@media` queries to verify user preferences.
Props wildworks, sainathpoojary, abcd95, joedolson, audrasjb.
Fixes#62806.
Built from https://develop.svn.wordpress.org/trunk@59989
git-svn-id: http://core.svn.wordpress.org/trunk@59331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When some screen option input fields are changed (post table columns, welcome panel, and metabox visibility), the change is saved to options. Other screen options (e.g. number of items per page) are only saved on submit. The changes that are saved immediately are visibly changed for sighted readers immediately. Change adds a `wp.a11y.speak()` call to inform screen readers that a value change has updated screen options.
Props kkmuffme, joedolson, yogeshbhutkar, audrasjb, sourabhjain.
Fixes#62550.
Built from https://develop.svn.wordpress.org/trunk@59988
git-svn-id: http://core.svn.wordpress.org/trunk@59330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Change the `onclick` attribute to a separate inlined script in the error message and improve the event attachment behavior.
Props vivekawsm, mijotj, adamsilverstein, parthvataliya, adhun, sarathar, peterwilsoncc, sayedulsayem, chaion07, sppramodh, indirabiswas27, aishwarryapande, dhrumilk, manojmaharrshi, ugyensupport, imranhasanraaz, pkbhatt, shailu25, joedolson.
Fixes#60074.
Built from https://develop.svn.wordpress.org/trunk@59986
git-svn-id: http://core.svn.wordpress.org/trunk@59328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When using a non-direct filesystem, the call in `WP_Upgrader::maintenance_mode()` did not include the required credentials, leading to a fatal error as the connection was not initialized properly.
This commit attempts to use the stored credentials if available, and triggers a notice otherwise.
Follow-up to [56341], [58128].
Props hideishi, dd32, SergeyBiryukov.
Fixes#62718.
Built from https://develop.svn.wordpress.org/trunk@59981
git-svn-id: http://core.svn.wordpress.org/trunk@59323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset removes the `aria-describedby` attribute when not editing the current user, as no description paragraph is associated.
Props kkmuffme, audrasjb, faisal03, shailu25, nandow, eddystile, marineevain, qhaensler, virginienacci.
Fixes#63006.
Built from https://develop.svn.wordpress.org/trunk@59978
git-svn-id: http://core.svn.wordpress.org/trunk@59320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Change several error message across core to use WordPress standard styling. Ensure only prefixes are wrapped in `strong` tags rather than the whole message, use `notice notice-error` classes where appropriate, and replace a custom error with `wp_admin_notice()` in multisite.
Props afercia, rajinsharwar, robinmartijn, mukesh27, sabernhardt, oglekler, joedolson, chaion07, im3dabasia1, audrasjb, dkarfa, najmulsaju.
Fixes#50402.
Built from https://develop.svn.wordpress.org/trunk@59960
git-svn-id: http://core.svn.wordpress.org/trunk@59302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Add URL validation in the admin navigation menu manager that matches the validation in the customizer when adding custom links. Improve accessibility of both custom link forms by adding `aria-invalid` and `aria-describedby` attributes with visible error messages and announcing the error using `wp.a11y.speak()`.
Props joedolson, nikitasolanki1812, akrocks, pathan-amaankhan, rcreators, ironprogrammer, audrasjb, ankit-k-gupta, chaion07, rinkalpagdar, snehapatil02, jainil07, parthvataliya.
Fixes#60619, #60969.
Built from https://develop.svn.wordpress.org/trunk@59948
git-svn-id: http://core.svn.wordpress.org/trunk@59290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset replaces `sanitize_text_field()` with `esc_url_raw()` for URLs passed via `url` and `return` query vars. This fixes an issue where the URL `example.com/หน้าภาษาไทย` would incorrectly return `example.com//` due to improper sanitization when clicking on the Customize button through the admin bar.
Props okvee, yahaly, hellofromTonya, veryard, dilip2615, amin7, swissspidy, audrasjb.
Fixes#61317.
Built from https://develop.svn.wordpress.org/trunk@59945
git-svn-id: http://core.svn.wordpress.org/trunk@59287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset fixes some issues where Select fields were misaligned with neighboring elements, creating visual inconsistency in the customizer.
Props rkradadiya, mukesh27, laxman-prajapati, dlh, karmatosed, ankitkumarshah, sabernhardt.
Fixes#51249.
Built from https://develop.svn.wordpress.org/trunk@59942
git-svn-id: http://core.svn.wordpress.org/trunk@59284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset fixes an issue where the `link_updated` field was not updated in the old Link Manager. When a link was created or updated the `link_updated` field remained `0000-00-00 00:00:00`.
Props lenasterg, audrasjb.
Fixes#56851.
Built from https://develop.svn.wordpress.org/trunk@59923
git-svn-id: http://core.svn.wordpress.org/trunk@59265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This modifies the submenu for the Site Editor which previously linked directly to the Patterns page after [58278] to support accessing the Stylebook in classic themes via a new "Design" link. Currently, any classic themes that have either added support for `editor-styles` or have a theme.json file will automatically see this new link in the admin menu.
Props isabel_brison, poena, wildworks, mamaduka, karmatosed, joemcgill.
Fixes#62509.
Built from https://develop.svn.wordpress.org/trunk@59905
git-svn-id: http://core.svn.wordpress.org/trunk@59247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Enable `download_url()` to fetch and verify file types if the URL does not contain a file extension. This allows URL downloads to handle media endpoints like istockphoto.com that use file IDs and formatting arguments to deliver images.
Props masteradhoc, mitogh, joedolson, hellofromTonya, antpb, audrasjb, navi161, dmsnell.
Fixes#54738.
Built from https://develop.svn.wordpress.org/trunk@59902
git-svn-id: http://core.svn.wordpress.org/trunk@59244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Adds a check of the `editable_roles` filter when adding users to a multisite sub-site to ensure the role is permitted to be used on the network. If the role is blocked by the filter, attempting to add the role will trigger a `wp_die()` similar to attempting to add a user with the role on a single site install.
Props eartboard, hareesh-pillai, ideag, sukhendu2002, spacedmonkey, thomaswm.
Fixes#43251.
Built from https://develop.svn.wordpress.org/trunk@59901
git-svn-id: http://core.svn.wordpress.org/trunk@59243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the header area of the theme and plugin file editor screen to make them more consistent. It now displays the name of theme or plugin, the active or inactive state, and the path to the file that is selected.
Props karmatosed, poena, audrasjb.
Fixes#41142.
Built from https://develop.svn.wordpress.org/trunk@59884
git-svn-id: http://core.svn.wordpress.org/trunk@59226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This reverts the full-white background update that was committed in [59705] to give it more time for testing and feedback. Let's revisit this proposal later and revert to the good ol’ grey background.
Props afercia, richtabor, karmatosed, johnjamesjacoby, johnbillion, sabernhardt,
See #62831.
Built from https://develop.svn.wordpress.org/trunk@59879
git-svn-id: http://core.svn.wordpress.org/trunk@59221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset introduces the `manage_users-network_custom_column` filter that fires for each custom column in the Network Users list table. This is an override hook for `manage_users_custom_column` which was already filtering each custom column in all Users list tables.
Props lenasterg, realloc, audrasjb.
Fixes#43318.
Built from https://develop.svn.wordpress.org/trunk@59878
git-svn-id: http://core.svn.wordpress.org/trunk@59220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset adjusts the padding for submenu link groups in the admin menu, ensuring consistent top and bottom padding.
Follow-up to [26072].
Props trushaamin, modi2918, hellofromTonya, peterwilsoncc, sabernhardt, im3dabasia1, audrasjb, karmatosed, dhrumilk.
Fixes#61689.
Built from https://develop.svn.wordpress.org/trunk@59875
git-svn-id: http://core.svn.wordpress.org/trunk@59217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset removes the `presentation` role from the Site Health debug tab tables to switch them into regular data tables, and updates the related stylesheet to keep the previously used styles.
Props audrasjb, hbhalodia, rvouill, mukesh27, sabernhardt, joedolson, alexstine.
Fixes#62880.
Built from https://develop.svn.wordpress.org/trunk@59859
git-svn-id: http://core.svn.wordpress.org/trunk@59201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset enhances the filesystem checks in the Site Health debug data by addressing the following:
- Existence Check: Before checking if the fonts directory is writable, it first verifies whether the directory exists.
- Improved Messaging: If the fonts directory does not exist, the debug output now reflects this scenario as "Does not exist". If the directory exists, it shows whether it is writable or not.
Props zodiac1978, samiamnot, sainathpoojary, abcd95, ankitkumarshah, im3dabasia1.
Fixes#62633.
Built from https://develop.svn.wordpress.org/trunk@59853
git-svn-id: http://core.svn.wordpress.org/trunk@59195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset brings more consistency by capitalizing the "Edit Site" strings located in the Toolbar and on the Site Editor screen.
Props bronsonquick, sabernhardt, audrasjb, peterwilsoncc, adamsilverstein.
Fixes#62971.
Built from https://develop.svn.wordpress.org/trunk@59850
git-svn-id: http://core.svn.wordpress.org/trunk@59192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
