[61018] was a good way to quickly limit the number of jobs spawned by the PHPUnit test workflow during the time leading up to beta releases for the 6.9 release, but this approach is not sustainable. This reverts that commit so a better long term solution can be explored in #64083.
See #63170, #64083.
Built from https://develop.svn.wordpress.org/trunk@61225
git-svn-id: http://core.svn.wordpress.org/trunk@60554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Per the [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#naming-conventions Naming Conventions]:
> Don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
This commit includes renaming of the following variables:
- `$post_ID` to `$post_id` — “Use lowercase letters in variable, action/filter, and function names”.
- `$ext_type` to `$extension_type`.
- `$ext` to `$extension`.
- `$id3data` to `$id3_data` — “Separate words via underscores”.
- `$msg` to `$message`.
- `$sb` to `$sidebar`.
- `$alt` to `$alternate`.
- `$pid` to `$post_id`.
- `$mid` to `$meta_id`.
- `$menu_obj` to `$menu_object`.
- `$noparents` to `$no_parents` — “Separate words via underscores”.
- `$sup` to `$supplemental`.
- `$cat_id` to `$category_id`.
- `$cat_name` to `$category_name`.
- `$out` to `$output`.
- `$r` to `$edit_result`.
- `$t` to `$taxonomy`.
- `$u` to `$update_result`.
- `$r` to `$result`.
- `$response` to `$response_data`.
- `$x` to `$response`.
Follow-up to [53723], [55365].
Props costdev, mukesh27, SergeyBiryukov.
See #64226.
Built from https://develop.svn.wordpress.org/trunk@61224
git-svn-id: http://core.svn.wordpress.org/trunk@60553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures clean environment in case of a previous test failure.
Follow-up to [56689].
Props aslamdoctor, wildworks, peterwilsoncc, SirLouen, mindctrl, kalpeshh, yashjawale, sachinrajcp123, SergeyBiryukov.
Fixes#63443.
Built from https://develop.svn.wordpress.org/trunk@61212
git-svn-id: http://core.svn.wordpress.org/trunk@60548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Previously, if any roles were filtered out via `array_filter()` when assigning the `WP_User::$roles` property in `WP_User::get_role_caps()`, the resulting array could contain non-sequential numeric keys, which would then cause it to be treated as an object when JSON-encoded, e.g. in `wp_localize_script()`, instead of a proper array, breaking client-side expectations.
This commit ensures that the `WP_User::$roles` property is always treated as an array.
Follow-up to [2703], [2793], [22118].
Props haruncpi, peterwilsoncc, SirLouen, getsyash, wildworks, johnjamesjacoby, SergeyBiryukov.
Fixes#63427.
Built from https://develop.svn.wordpress.org/trunk@61210
git-svn-id: http://core.svn.wordpress.org/trunk@60546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the following third-party GitHub Actions:
- `actions/github-script` from `7.0.1` to `8.0.0`.
- `actions/checkout` from `4.2.2` to `5.0.0`.
- `actions/setup-node` from `4.3.0` to `6.0.0`.
- `actions/upload-artifact` from `4.6.2` to `5.0.0`.
- `actions/cache` from `4.2.4` to `4.3.0`.
- `actions/download-artifact` from `5.0.0` to `6.0.0`.
- `shivammathur/setup-php` from `2.35.3` to `2.35.5`.
- `codecov/codecov-action` from `5.4.3` to `5.5.1`.
See #63170.
Built from https://develop.svn.wordpress.org/trunk@61209
git-svn-id: http://core.svn.wordpress.org/trunk@60545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the `devDependencies` for each of the default themes with `package.json` files with a few exceptions:
- `eslint`: This was updated to the latest `8.x` version only since `9.x` is not yet properly supported by `@wordpress/eslint-plugin`.
- `stylelint`-related packages: these updates are resulting in formatting changes. These need to be examined more carefully as they’re likely undesired and require adjustments to the configuration file.
Props peterwilsoncc, desrosj.
Fixes#63171.
Built from https://develop.svn.wordpress.org/trunk@61206
git-svn-id: http://core.svn.wordpress.org/trunk@60542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the following `devDependencies`:
- `@playwright/test` from `1.50.1` to `1.56.1`.
- `@pmmmwh/react-refresh-webpack-plugin` from `0.5.15` to `0.6.1`.
- `autoprefixer` from `10.4.20` to `10.4.22`.
- `chalk` from `5.4.1` to `5.6.2`.
- `copy-webpack-plugin` from `13.0.0` to `13.0.1`.
- `cssnano` from `7.0.6` to `7.1.2`.
- `dotenv` from `16.4.7` to `17.2.3`.
- `dotenv-expand` from `12.0.1` to `12.0.3`.
- `grunt-sass` from `4.0.0` to `4.0.1`.
- `postcss` from `8.5.3` to `8.5.6`.
- `qunit` from `2.23.1` to `2.24.2`.
- `sass` from `1.85.1` to `1.94.0`.
- `terser-webpack-plugin` from `5.3.12` to `5.3.14`.
- `uuid` from `11.1.0` to `13.0.0`.
- `wait-on` from `8.0.2` to `9.0.3`.
A new variable, `DOTENV_CONFIG_QUIET`, has been added to the `.env.example` file to silence tips output by the `dotenv` dependency.
Additionally, `npm audit fix` has been run.
Props peterwilsoncc, desrosj.
See #63171.
Built from https://develop.svn.wordpress.org/trunk@61205
git-svn-id: http://core.svn.wordpress.org/trunk@60541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Introducing the new content for the 6.9 About page. This release also introduce new header images across the About section.
See #63941.
Props desrosj, jeffpaul, 4thhubbard, priethor, annezazu, fcoveram, joedolson, ryelle, peterwilsoncc.
Built from https://develop.svn.wordpress.org/trunk@61204
git-svn-id: http://core.svn.wordpress.org/trunk@60540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Because `WordPress/wordpress-develop` is a mirror, the only way to contribute to WordPress on GitHub is by forking the repository (even when a contributor has write access as a Core Committer). This updates the “Getting Started” section to make this more clear.
The section about how to contribute using GitHub Codespaces is also being removed since this has been broken for some time (see #57896). This section can be reintroduced once the underlying tooling is fixed.
Props pbearne, desrosj, westonruter, wildworks, peterwilsoncc.
Fixes#64100. See #57896.
Built from https://develop.svn.wordpress.org/trunk@61202
git-svn-id: http://core.svn.wordpress.org/trunk@60538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This improves how `wp_mail()` handles `Content-Type` headers for multipart messages, preventing cases where the header could be duplicated.
Developed in https://github.com/WordPress/wordpress-develop/pull/9500
Props SirLouen, gitlost, rmccue, westi, MattyRob, bgermann, nacin, SergeyBiryukov, dd32, MikeHansenMe, Kleor, kitchin, JeffMatson, abcd95, westonruter, christinecooper, JohnVieth, dawidadach, imokweb, ayeshrajans, lakshyajeet, tusharbharti, sajjad67.
Fixes#15448.
Built from https://develop.svn.wordpress.org/trunk@61201
git-svn-id: http://core.svn.wordpress.org/trunk@60537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Per the [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#naming-conventions Naming Conventions]:
> Don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
This commit includes renaming of the following variables:
* `$i` to `$submenu_index`.
* `$cap` to `$capability`.
* `$tax` to `$taxonomy`.
* Several `$awaiting_mod_*` to `$awaiting_moderation_*`.
* Several `$ptype_*` to `$post_type_*`.
* `$types` to `$post_types`.
* `$appearance_cap` to `$appearance_capability`.
Follow-up to [12597], [14654], [21199], [23871], [33723], [33867].
Props costdev, SergeyBiryukov.
See #63168.
Built from https://develop.svn.wordpress.org/trunk@61200
git-svn-id: http://core.svn.wordpress.org/trunk@60536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Code maintenance follow up to r61179. Move `wp_new_comment_via_rest_notify_postauthor` callback from REST API Comments controller to comment.php. Add default to `wp_notes_notify` for multisite compatibility.
Props adamsilverstein, justlevine, mukesh27, mamaduka, peterwilsoncc, desros.
See #64204.
Built from https://develop.svn.wordpress.org/trunk@61199
git-svn-id: http://core.svn.wordpress.org/trunk@60535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Follow up to [61108].
Change type handling to ensure that falsey string values like `0` are correctly handled. Improves readability of underlying code by consolidating type checks and passing resulting array to the `wp_title_parts` filter.
Props tobiasbg, sabernhardt, sirlouen, wildworks, joedolson, mukesh27.
Fixes#61352.
Built from https://develop.svn.wordpress.org/trunk@61198
git-svn-id: http://core.svn.wordpress.org/trunk@60534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fix for fatal errors caused by incorrect closing tags in HTML, such as `</br>`. In these cases, the `get_attribute_names_with_prefix` method of the `WP_HTML_Tag_Processor` returns `null`, and the Interactivity API was not handling this situation correctly.
Props hugosolar, jonsurrell, darerodz.
Fixes#63891.
Built from https://develop.svn.wordpress.org/trunk@61197
git-svn-id: http://core.svn.wordpress.org/trunk@60533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that the presence of a self-signed certificate from a MySQL/MariaDB container will not cause `db` WP-CLI commands run using `env:cli` in the local development environments to fail.
Follow up to [60735].
Props westonruter, mukesh27.
Fixes#64128. See #63876.
Built from https://develop.svn.wordpress.org/trunk@61196
git-svn-id: http://core.svn.wordpress.org/trunk@60532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Updates the endpoint for Twemoji images to use those released in 17.0.2, following an upstream minor release optimizing the SVG images.
Modifies the build script to pull the image file names from the `gh-pages`/deploy branch of Twemoji upon the advice of their contributors.
Props peterwilsoncc, paulkevan, wildworks, desrosj.
Fixes#64184.
Built from https://develop.svn.wordpress.org/trunk@61194
git-svn-id: http://core.svn.wordpress.org/trunk@60530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The changes in [60942] aimed to add an indicator next to the default date and time formats for the site’s locale in General Settings. However, the changes do not take into account the fact that a user may have a different language than the site’s default selected as their preference.
Props swissspidy, johnbillion, SergeyBiryukov, pbearne, desrosj, wildworks.
See #64102.
Built from https://develop.svn.wordpress.org/trunk@61193
git-svn-id: http://core.svn.wordpress.org/trunk@60529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This avoids using multisite-specific tables and columns in `WP_Date_Query::validate_column()` when on a non-multisite install. Attempting to use `$wpdb->blogs` as an array index when `null` on a non-multisite install causes a deprecation notice in PHP 8.5. This also updates the multisite table alias in `wpdb` to make it clear they could be `null`.
Developed in https://github.com/WordPress/wordpress-develop/pull/10498
Follow-up to [60904], [60809], [37477].
Props westonruter, desrosj.
See #63061.
Fixes#63957.
Built from https://develop.svn.wordpress.org/trunk@61191
git-svn-id: http://core.svn.wordpress.org/trunk@60527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Includes:
* Converting data provider methods to `static` for a slight performance improvement.
* Correcting annotations for consistency.
Follow-up to [53033], [53125], [54161].
Props mukesh27, SergeyBiryukov.
See #63167.
Built from https://develop.svn.wordpress.org/trunk@61185
git-svn-id: http://core.svn.wordpress.org/trunk@60521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fix an issue where adding comment_type=note as a query parameter to the wp-admin/edit-comments.php page would unexpectedly cause notes to show. Notes are different from comments - prevent them from showing on the comment list table.
Props adamsilverstein, desros, soyebsalar01j.
Fixes#64198.
Built from https://develop.svn.wordpress.org/trunk@61183
git-svn-id: http://core.svn.wordpress.org/trunk@60519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This addresses a performance issue in the recursive `WP_Scripts::get_highest_fetchpriority_with_dependents()` and `WP_Scripts::filter_eligible_strategies()` methods for redundant processing of shared dependencies in complex dependency graphs. To fix this, a `$stored_results` param is introduced which is passed by reference; this variable contains a cache of the calculated results for all scripts handles, so that subsequent calls for the same handle can return the cached value instead of re-computing it.
Developed in https://github.com/WordPress/wordpress-develop/pull/10459
Follow-up to [60704], [60931], [56033].
Props ciobanucatalin, b1ink0, westonruter, mukesh27.
See #61734, #12009.
Fixes#64194.
Built from https://develop.svn.wordpress.org/trunk@61176
git-svn-id: http://core.svn.wordpress.org/trunk@60512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that on-demand block styles are inserted right after the `wp-block-library` inline style whereas other stylesheets not related to blocks are appended to the end of the `HEAD`. This helps ensure the expected cascade is preserved. If no `wp-block-library` inline style is present, then all styles get appended to the `HEAD` regardless.
The handling of the CSS placeholder comment added to the `wp-block-library` inline style is also improved. It is now inserted later to ensure the inline style is printed. Additionally, when the CSS placeholder comment is removed from the `wp-block-library` inline style, the entire `STYLE` tag is now removed if there are no styles left (aside from the `sourceURL` comment).
Lastly, the use of the HTML Tag Processor is significantly improved to leverage `WP_HTML_Text_Replacement`.
Developed in https://github.com/WordPress/wordpress-develop/pull/10436
Follow-up to [61008].
Props westonruter, peterwilsoncc, dmsnell.
Fixes#64099.
Built from https://develop.svn.wordpress.org/trunk@61174
git-svn-id: http://core.svn.wordpress.org/trunk@60510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Dates without leading zeros (e.g., `2012-1-08`, `2012-01-8`) are now correctly recognized as valid dates. This change fixes the test cases to correctly reflect that these formats are valid and fixes an undefined variable reference.
Follow-up to [61172].
Props wildworks, westonruter.
Fixes#26798.
Built from https://develop.svn.wordpress.org/trunk@61173
git-svn-id: http://core.svn.wordpress.org/trunk@60509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit updates `wp_resolve_post_date()` to use a regular expression for parsing the date string into year, month, and day matches. This approach handles missing leading zeros more reliably than `substr()` while remaining performant (see #57683).
It also adds checks and type-casting to `wp_checkdate()` variables before passing them into PHP's `checkdate()` function to avoid the potential for a `TypeError` in PHP 8 and newer (see #54186).
Lastly, it includes 2 new unit tests (with data providers) to cover an array of valid and invalid date formats (YYYY-MM-DD, YYYY-MM-DD HH:MM:SS, ISO 8601, RSS, leap years, malformed inputs, etc...)
Props alordiel, desrosj, johnbillion, johnjamesjacoby, johnregan3, modius5150, nacin, pbearne.
Fixes#26798.
Built from https://develop.svn.wordpress.org/trunk@61172
git-svn-id: http://core.svn.wordpress.org/trunk@60508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This adds `is_string()` type checks for the `$post_status` arg passed to both `get_post_status_object()` and `is_post_status_viewable()`. This was triggered by `Tests_Post_IsPostStatusViewable::test_built_in_and_unregistered_status_types()` for the `null` data set.
Follow-up to [61170].
See #63167, #63061.
Built from https://develop.svn.wordpress.org/trunk@61171
git-svn-id: http://core.svn.wordpress.org/trunk@60507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Includes:
* Adding the missing `@covers` annotation.
* Converting data provider methods to `static` for a slight performance improvement.
* Using named data providers.
Follow-up to [50130].
Props mukesh27, swissspidy, SergeyBiryukov.
See #63167.
Built from https://develop.svn.wordpress.org/trunk@61170
git-svn-id: http://core.svn.wordpress.org/trunk@60506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
