Changeset [60007] updated some TinyMCE-related files but did not update the $tinymce_version cache key located in wp-includes/version.php. This changeset updates the cache key with the date of the last changes.
Follow-up to [60007].
Merges [60413] to the 6.8 branch.
Props oferlaor, sabernhardt, siliconforks, audrasjb.
Fixes#63308.
Built from https://develop.svn.wordpress.org/branches/6.8@60436
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
There has been a memory inefficiency inside of `do_blocks()` where it
parses the given content then iterates through each top-level block to
render it. Unfortunately each top-level block can considerably add to
the overall memory use involved, and once moving on to the next
top-level block, all of the allocated memory will be retained until the
end of the call to `do_blocks()`.
In this change, each parsed block sub-tree is freed via reset to null
after it has been rendered. All top-level blocks are rendered
independently of each other and so this operation is safe — there are no
data dependencies between them.
This commit also includes follow-up changes committed in [60400] and [60402].
Rewieved by audrasjb.
Merges [60316], [60400] and [60402] to the 6.8 branch.
Props dmsnell, joemcgill.
Fixes#63588.
Built from https://develop.svn.wordpress.org/branches/6.8@60435
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset introduces a development mode for block editor styles. When SCRIPT_DEBUG is enabled, block editor styles now use the file modification time as their version, ensuring cache busting during development. This matches the behavior that already exists for block scripts.
Previously, block editor styles only used the version from block.json, which doesn't change during development, causing styles to be cached even after changes.
Merges [60355] to the 6.8 branch.
Props helgatheviking, abcd95, gziolo, whaze, audrasjb, sandeepdahiya, rollybueno.
Fixes#63254.
Built from https://develop.svn.wordpress.org/branches/6.8@60434
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset replaces get_parent_theme_file_uri( 'assets/css/editor-style.css' ) with add_editor_style( 'assets/css/editor-style.css' ); to ensure a relative path to the stylesheet file is used, and not an URL. This prevents the editor stylesheet from not being enqueued on various edge cases.
Merges [60424] to the 6.8 branch.
Props wildworks, sabernhardt, dhruvang21, karmatosed, SirLouen, audrasjb, sandeepdahiya.
Fixes#63399.
Built from https://develop.svn.wordpress.org/branches/6.8@60433
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
* Start `cli` container when running `env:start`. This greatly speeds up calls to WP-CLI since the container is already running rather than having to start up for each call.
* Facilitate calls to `env:cli` in non-interactive context (non-TTY) to allow piping content into commands or use in shell scripts.
* Fix passing arguments to WP-CLI from `env:cli` so that arguments with spaces are passed as expected.
* Fix JSHint issues.
This aligns the wordpress-develop environment closer to wp-env. See https://github.com/WordPress/gutenberg/pull/50007.
Reviewed by audrasjb.
Merges [60308] to the 6.8 branch, minus the change to `.github/workflows/reusable-test-local-docker-environment-v1.yml` which was made irrelevant in [60092].
Props westonruter, jorbin, SirLouen, sandeepdahiya.
Fixes#63564.
Built from https://develop.svn.wordpress.org/branches/6.8@60432
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
* Force WP-CLI to use the `wp-config.php` in the directory above the `src` directory via the `WP_CONFIG_PATH` environment variable [read by WP-CLI](2800ad0a66/php/utils.php (L328-L329)) in the `wp_locate_config()` function.
* Update the `env:install` command to write out the config at the repo root instead of writing it inside of the `ABSPATH` only then to move it one directory up.
* Fix JSHint issues.
* Add error handling to when `npm run env:install` is executed without having first done `npm run env:start`, in which case the script will end with an exit code of 1 and emit:
> Error: It appears the development environment has not been started. Message: Timed out waiting for: tcp:localhost:8000
> Did you forget to do 'npm run env:start'?
Reviewed by audrasjb.
Merges [60305] to the 6.8 branch.
Fixes#63543.
Props westonruter, jorbin, SirLouen.
Built from https://develop.svn.wordpress.org/branches/6.8@60431
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the default on new installations for rpc.pingomatic.com to use https while also upgrading existing sites that use rpc.pingomatic.com or rpc.twingly.com to use https for those two domains.
Reviewed by audrasjb.
Merges [60421] and [60422] to the 6.8 branch.
Props sabernhardt, peterwilsoncc, jorbin, bhubbard, matt.
Fixes#42007.
Built from https://develop.svn.wordpress.org/branches/6.8@60428
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The plain style for quote block was not showing in the editor despite showing on the front. This patch now makes sure it also does not show the border in editor.
Reviewed by audrasjb, karmatosed.
Merges [60342] to the 6.8 branch.
Props nidhidhandhukiya, dilipbheda, sabernhardt, sainathpoojary, dhruvang21, harshgajipara, SirLouen, darshitrajyaguru97, jorbin.
Fixes#63424.
Built from https://develop.svn.wordpress.org/branches/6.8@60426
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The white link text had worked against the dark background of the Primary and Footer widget areas, but not against the light background in the Content Sidebar. Therefore, r60368 excludes the Content Sidebar from that ruleset.
Reviewed by audrasjb.
Merges [60368] to the 6.8 branch.
Props sabernhardt, dhruvang21, ravigadhiyawp, sandeepdahiya.
Fixes#63520.
Built from https://develop.svn.wordpress.org/branches/6.8@60425
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The `load` event (on `window`) fires after all resources on a page have been loaded, including images. This means that
on a slow connection, the mobile nav menu button may be rendered yet unresponsive to taps between when it first appears
and when the page has fully loaded. This is rectified by switching to the `DOMContentLoaded` event so that the nav menu
behaviors are attached as soon as the DOM has fully loaded.
Reviewed by audrasjb.
Merges [60352] to the 6.8 branch.
Props gernberg, westonruter, sabernhardt.
Fixes#63613.
Built from https://develop.svn.wordpress.org/branches/6.8@60423
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Include the image height and width in the attributes passed to the `wp_get_attachment_image_attributes` filter. Developers can use this to adjust the width and height attributes returned from the `wp_get_attachment_image_attributes` function.
Reviewed by audrasjb.
Merges [60415] to the 6.8 branch.
Props divinenephron, nacin, Sam_a, wpsmith, anatolbroder, ericlewis, puggan, SergeyBiryukov, spacedmonkey, adamsilverstein, flixos90, sandeepdahiya, SirLouen.
Fixes#14110.
Built from https://develop.svn.wordpress.org/branches/6.8@60420
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Browser support for client-side validation is now reliable. Blocking the form submission when there is a missing/invalid field prevents the possibility of losing comment content when bfcache does not restore the previous page when going back.
To retain the `novalidate` attribute, the `comment_form()`'s args now accepts a `novalidate` key which will add the attribute when it is `true`. This can also be supplied by the `comment_form_default_fields filter`, for example:
{{{
add_filter( 'comment_form_defaults', function ( $args ) {
$args['novalidate'] = true;
return $args;
} );
}}}
Reviewed by audrasjb.
Merges [60304] to the 6.8 branch.
Fixes#47595.
Props westonruter, joedolson, sabernhardt, afercia, SergeyBiryukov, guddu1315, pfefferle, oglekler, bugnumber9.
Built from https://develop.svn.wordpress.org/branches/6.8@60412
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The `sanitize_file_name()` function normalizes the no-break space to a normal space (`U+0020`) in order to prevent issues saving files with the no-break space in it.
This patch expands the replacement to all space characters, since it’s known that macOS stores a `NARROW NO-BREAK SPACE` (`U+202F`) in screenshot filenames between the time and the am/pm indicator.
There are deeper issues with the way this function works, but this patch resolves a known and common problem without raising any of the deeper refactoring questions.
Reviewed by audrasjb, youknowriad.
Merges [60399] to the 6.8 branch.
Props audrasjb, desrosj, dmsnell, jonsurrell, matt, room34, siliconforks, zieladam, annezazu.
Fixes#62995.
Built from https://develop.svn.wordpress.org/branches/6.8@60411
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
On small screens, the restore revision button was mostly hidden due to excessive constraints on overflow height. Fix the overflow issue and ensure that restore revision buttons are always usable.
Reviewed by audrasjb.
Merges [60259] to the 6.8 branch.
Props yogeshbhutkar, getsyash, joedolson.
Fixes#63029.
Built from https://develop.svn.wordpress.org/branches/6.8@60410
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Screencast have updated their URL structure to use a sub-domain and the prior oEmbed endpoint in the allow list now returns a 410 Gone response.
For discussion regarding the legacy endpoint refer to #61941, comment #35 onwards.
Merges [60345] to the 6.8 branch.
See #61941.
Props audrasjb, brhodes, dustintechsmith, joedolson, johnbillion, nikunj8866, paulstanos, peterwilsoncc, sandeepdahiya, sergeybiryukov, sirlouen, swissspidy.
Built from https://develop.svn.wordpress.org/branches/6.8@60354
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Introduces support for Emoji 16:
- replaces emoji support test with splatter ,
- replaces two letter coded flag support test with Sark 🇨🇶,
- introduces the function `emojiRendersEmptyCenterPoint()` to the emoji loader to enable testing of emoji with a single data point.
Not to harp on about it, but Emoji 16 is perfect for tiring yourself out digging up root vegetables while visiting Sark 🇨🇶.
Reviewed by audrasjb.
Merges [60227] to the 6.8 branch.
Props westonruter, kraftbj, pento, JeffPaul, abcd95, SergeyBiryukov, dd32, peterwilsoncc.
Fixes#63324.
Built from https://develop.svn.wordpress.org/branches/6.8@60317
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Introduces tests to ensure the version numbers in `package-lock.json` (two instances) and `composer.json` match the WordPress version specified in `version.php`.
In pull requests, the `package-lock.json` file is updated automatically to match the version in `package.json`. The new test is intended to ensure the version numbers are correct in production branches.
Reviewed by jorbin.
Merges [60219], [60221] to the 6.8 branch.
Fixes#63390.
Built from https://develop.svn.wordpress.org/branches/6.8@60223
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The lack of a specified version in the composer.json file is causing some unexpected warnings.
Reviewed by peterwilsoncc.
Merges [60211], [60212] to the 6.8 branch with appropriate version number modifications.
Props sirlouen, johnbillion, TobiasBg, desrosj, jorbin.
See #63167.
Built from https://develop.svn.wordpress.org/branches/6.8@60218
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This restores the 6.7 and below behavior for the posts endpoint which did not include sticky posts by default.
Follow-up to [59801].
Reviewed by desrosj.
Merges [60197] to the 6.8 branch.
Props nikunj8866, SirLouen, ankitmaru, wildworks, karthikeya01, Mamaduka, spacedmonkey, jorbin.
Fixes#63307. See #35907.
Built from https://develop.svn.wordpress.org/branches/6.8@60200
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
While having a mime type with an "image" prefix, SVG images are in fact "Scalable Vector Graphics" that can be scaled directly.
Follow-up to [60084].
Reviewed by desrosj.
Backports [60195] to the 6.8 branch.
Props sirlouen, adamsilverstein, audrasjb, pbiron, sainathpoojary, dilipbheda, pratiklondhe.
Fixes#63302. See #61167.
Built from https://develop.svn.wordpress.org/branches/6.8@60196
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This reverts [59910] and changes the "Edit Site" link to be the current template rather than the top-level screen of the Site Editor.
Reviewed by SergeyBiryukov, desrosj.
Merges [60193] to the 6.8 branch.
Props wildworks, joemcgill, poena, westonruter, nickwilmot, marktimemedia, eduwass, lilgames, codeamp, jeffr0, jorbin.
Fixes#63358. See #62368.
Built from https://develop.svn.wordpress.org/branches/6.8@60194
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In finalizing the 6.8 announcement post (https://wordpress.org/news/2025/04/cecil/) it was identified that some of the copy on the 6.8 about page is not an accurate description of what is in 6.8. This copy is receiving a game misconduct penalty and automatic ejection. While the coach could bring on a substitute, a line change is the better option here.
Reviewed by joedolson.
Merges [60183] to the 6.8 branch.
Props abcd95, mukesh27, JeffPaul.
Fixes#63323.
Built from https://develop.svn.wordpress.org/branches/6.8@60190
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
As of [59523], Block Hooks are applied to post content. In order to allow for insertion of a hooked block as first_child or last_child of the containing Post Content block, we wrap the block's post content (as obtained from the DB) in a temporary <!-- wp:post-content --> wrapper block, apply the Block Hooks algorithm to the resulting markup, and remove the wrapper block. (The same technique is applied for the Synced Pattern block -- see [59543] -- as well as the Navigation block.)
However, this caused a problem when a hooked block was marked for insertion before before or after a Post Content block: The logic that's supposed to remove the temporary wrapper block after the Block Hooks algorithm runs erroneously removed that hooked block's delimiter instead of the wrapper block, producing garbled markup as a result.
This changeset fixes the issue by adding a hooked_block_types filter (with PHP_INT_MAX priority) that removes any blocks hooked before or after a Post Content block, if the current context is a post object. This prevents any blocks hooked that way from being "absorbed" into the corresponding post object's content; it retains the ability to hook blocks before and after a Post Content block in any other context (e.g. a template). (The same principle is applied to Synced Pattern and Navigation blocks.)
Reviewed by Jorbin.
Merges [60173] to 6.8 branch.
Props obenland, jorbin, gziolo, bernhard-reiter.
Fixes#63287.
Built from https://develop.svn.wordpress.org/branches/6.8@60189
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Because validation was added in [59134] to prevent submitting bulk actions with no selected action, sites that remove or change the default bulk actions can fail due to the missing required inputs. Add a filter (bulk_action_observer_ids) that allows modifying the actions accepted to fulfill validation rules.
Reviewed by Jorbin.
Merges [60186] to the 6.8 branch.
Props ethitter, kabir93, jorbin, davidbaumwald, joedolson.
Fixes#63005.
Built from https://develop.svn.wordpress.org/branches/6.8@60188
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
[59696] changed the 'Text' tab of the classic editor to 'Code' but Code was already used as a key in the array of translatable text. Since arrays keys need to be unique, this meant that it is possible for the wrong translation to appear in a locale. Using different keys fixes that.
Reviewed by joedolson.
Merges [60182] to the 6.8 branch.
Props joedolson, sabernhardt, justlevine, swissspidy, audrasjb.
Fixes#63269. See #38061.
Built from https://develop.svn.wordpress.org/branches/6.8@60187
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When using a non-direct filesystem, the call in WP_Upgrader::maintenance_mode() did not include the required credentials, leading to a fatal error as the connection was not initialized properly.
This commit attempts to use the stored credentials if available, and triggers a notice otherwise.
Follow-up to [56341], [58128].
Reviewed by jorbin.
Merges [60107] to the 6.8 branch.
Props SirLouen, hideishi, dd32, tusharaddweb, takuword, SergeyBiryukov.
Fixes#62718.
Built from https://develop.svn.wordpress.org/branches/6.8@60184
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Removes a call to the `is_super_admin()` function in `ms-files.php` as the function isn't available when using the `SHORTINIT` feature, causing fatal errors on systems using file rewrites.
Reverts [59967].
Reviewed by jorbin.
Merges [60170] to the 6.8 branch.
Props audrasjb, desrosj, jeremyfelt, johnjamesjacoby, jorbin, presskopp, verygoode, dd32, joemcgill.
See #36803.
Fixes#63285.
Built from https://develop.svn.wordpress.org/branches/6.8@60171
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
An update for these two default themes will not be released in coordination with WordPress 6.8 due because there were no changes to the source code during the release cycle. However, they should be considered tested with 6.8, and this ensures that the next release properly indicates that.
Reviewed by joemcgill.
Merges [60158] to the 6.8 branch.
Props shailu25, sabernhardt, desrosj, poena, audrasjb.
See #62990.
Built from https://develop.svn.wordpress.org/branches/6.8@60161
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
[59775] resulted in a backwards compatibility break in a now deprecated experimental component, which was stabilized to `LinkControl`. When experimental components are deprecated in favor of being stabilized, the same backwards compatibility policy applies and the shape of the component should not change.
This restores the static properties that were unintentionally removed from the `__experimentalLinkControl` component that was moved to `DeprecatedExperimentalLinkControl`.
Reviewed by joemcgill, wildworks.
Merges [60150] to the 6.8 branch.
Props karthikeya01, mamaduka, joemcgill, fabiankaegy, wildworks.
Fixes#62887.
Built from https://develop.svn.wordpress.org/branches/6.8@60156
git-svn-id: http://core.svn.wordpress.org/branches/6.8@59492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
