`line-height` values that were previously used to match the height of input fields affect the height of the background shown when text inside those fields is selected. Removing these `line-height` declarations allows the text selection highlight to render more naturally.
Additionally, update the height of the custom Date/Time format input fields on the General Settings screen to `32px` to align with the new design system.
Props arkaprabhachowdhury, audrasjb, hmrisad, huzaifaalmesbah, manhar, manishxdp, noruzzaman, ozgursar, r1k0, sachinrajcp123, wildworks.
Fixes#64763.
Built from https://develop.svn.wordpress.org/trunk@62171
git-svn-id: http://core.svn.wordpress.org/trunk@61453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
A test in the `external-http` group that detects when the recommended version of MySQL is too old is failing due to an upstream change to the content of version documentation pages.
Because the required information is no longer on the page, this switches to using the public API from endoflife.date. This site is an open source (MIT licensed) resource that is actively maintained.
Props peterwilsoncc.
See #64894.
Built from https://develop.svn.wordpress.org/trunk@62170
git-svn-id: http://core.svn.wordpress.org/trunk@61452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Configured the Real Time Collaboration post type to be excluded from exports by default. The data is considered ephemeral and includes data on post IDs that may not match the IDs of posts on the importing site.
Introduces a test to the export test suite to ensure that post types set to be excluded from exports are, in fact, excluded from exports.
Props peterwilsoncc, desrosj, westonruter, jorbin, mukesh27, czarate.
Fixes#64964.
Built from https://develop.svn.wordpress.org/trunk@62168
git-svn-id: http://core.svn.wordpress.org/trunk@61450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In [61873], the `build` script started failing in some environemnts due to logic that added a requirement for `php-cli`.
While WordPress itself cannot be run without PHP, the build script has never required PHP to be present to prepare `wordpress-develop` for use. This adjusts the relevant code to make use of the `php-array-reader` package instead.
Reviewed by peterwilsoncc.
Props dmsnell, peterwilsoncc, gaisma22, SirLouen, sabernhardt, manhar.
Fixes#64925. See #64393.
Built from https://develop.svn.wordpress.org/trunk@62157
git-svn-id: http://core.svn.wordpress.org/trunk@61439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
After [62117] through [62144] along with [62147] through [62149], a number of block directories included css files as the result of `npm build`. To fix this and prevent a recurrence when new blocks are added, this moves from the `svn:ignore` property needing to be set on each individual directory to using the `svn:global-ignores` property which is recursive.
This was accomplished by running the following commands:
{{{
svn propdel svn:ignore -R src/wp-includes/blocks/*
svn propset svn:global-ignores '*.css
*.js
*.js.map' src/wp-includes/blocks
}}}
Discussed in https://wordpress.slack.com/archives/C08D0Q6BHNY/p1774546046110849
Reviewed-by:dmsnell and jonsurrell.
Props dmsnell, johnbillion, jonsurrell, jorbin.
See #64393.
Built from https://develop.svn.wordpress.org/trunk@62155
git-svn-id: http://core.svn.wordpress.org/trunk@61437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Since button and media view CSS can sometimes be enqueued by extenders in contexts where either `wp-base-styles` are not present or the `body` wrapper class is omitted, these variables should use fallback values.
Reviewed by audrasjb.
Props huzaifaalmesbah, wildworks, mukesh27, noruzzaman, joedolson, sabernhardt, audrasjb, shailu25.
Fixes#64840.
Built from https://develop.svn.wordpress.org/trunk@62154
git-svn-id: http://core.svn.wordpress.org/trunk@61436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When RTC is enabled, let the "Join" action link in the post list turn into "Edit" after the post lock expires. Do this by rendering both "Edit" and "Join" as separate spans and toggling visibility via CSS using the `wp-collaborative-editing` class that heartbeat already manages. Do the same to aria-label with screen-reader-text spans so the accessible name stays in sync with the visible text across lock state changes.
Developed in https://github.com/WordPress/wordpress-develop/pull/11346.
Follow-up to [62074].
Props shekharnwagh.
See #64622.
Built from https://develop.svn.wordpress.org/trunk@62146
git-svn-id: http://core.svn.wordpress.org/trunk@61428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset ensures the styles for bar, highlight and contextual help always take into account the admin color scheme settings.
Reviewed by joedolson.
Props fabiankaegy, audrasjb, ozgursar, noruzzaman, shailu25, sandipsinh007, tusharaddweb, hbhalodia, amesplant, joedolson.
Fixes#64744.
See #64308.
Built from https://develop.svn.wordpress.org/trunk@62145
git-svn-id: http://core.svn.wordpress.org/trunk@61427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commits changes to built files that were not included in the previous commit that restored version history for files that were previously subject to version control.
This also reverts [62069], which was a temporary fix to ensure deleted files that are no longer desired were cleaned up on the build server prior to committing the changes.
Finally, the `src/wp-includes/build` and all its contents to the exclusion list for PHPCS scans. There are small coding standards failures in these files that need to be resolved upstream before the scan will pass on this directory.
Props dmsnell, ellatrix, desrosj.
See #64393.
Built from https://develop.svn.wordpress.org/trunk@62144
git-svn-id: http://core.svn.wordpress.org/trunk@61426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In [61438] and successive fixes, a number of files were deleted and added to `.gitignore`. These files were removed because they are built from the Gutenberg repo and copied into the Core repo. However, because the only artifact of udpates to those files are an opaque hash change, it’s important to have a copy of the files at the change in version control for the purposes of auditing, debugging, benchmarking, and tracking.
This patch merges a version-history from before the initial changeset and reattaches the version-tracking to these files, creating immitation commits along each step where the files were updated in a Gutenberg sync.
Developed in: https://github.com/WordPress/wordpress-develop/pull/11064
Discussed in: https://core.trac.wordpress.org/ticket/64393
Follow-up to [61438].
Props 762e5e74, aidvu, desrosj, dmsnell, jonsurrell, youknowriad.
See #64393.
Built from https://develop.svn.wordpress.org/trunk@62143
git-svn-id: http://core.svn.wordpress.org/trunk@61425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
`WP_Connector_Registry::register()` always auto-generates the `setting_name`
for connectors with `api_key` authentication, ignoring any caller-provided
value. This prevents connectors from using existing WordPress options as their
API key storage.
This change checks for a non-empty `setting_name` in the provided args before
falling back to the auto-generated name.
Props jorgefilipecosta, gziolo.
Fixes#64957.
Built from https://develop.svn.wordpress.org/trunk@62116
git-svn-id: http://core.svn.wordpress.org/trunk@61398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Add CSS & update selectors so that controls added in the `extra_tablenav` region of list tables inherit the compact sizing used by core table nav controls.
Reviewed by johnbillion.
Props johnbillion, hbhalodia, mukesh27, sabernhardt, abdullah17, r1k0, joedolson, nilambar, shailu25.
Fixes#64796.
Built from https://develop.svn.wordpress.org/trunk@62115
git-svn-id: http://core.svn.wordpress.org/trunk@61397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fixes the following two patterns:
- Navigation Overlay: Add explicit black text and link colors so the default overlay pattern remains readable even when the active theme uses white text.
- Overlay with site info and CTA: Fix invalid block attributes to prevent the block from breaking.
Follow-up to [61609].
Props isabel_brison, mikachan, onemaggie, westonruter, wildworks.
See #64589.
Built from https://develop.svn.wordpress.org/trunk@62114
git-svn-id: http://core.svn.wordpress.org/trunk@61396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Match the `:hover` and `:focus` states in the admin sidebar, restoring the sharp-edged border used prior to the admin reskin. Remove the 2px border radius from focused admin sidebar links.
Props juanfra, audrasjb, niravsherasiya7707, khushi1501, shailu25, joedolson.
Fixes#64860.
Built from https://develop.svn.wordpress.org/trunk@62108
git-svn-id: http://core.svn.wordpress.org/trunk@61390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Increase the style contrast between pressed and un-pressed button states by using enhanced box-shadow to differentiate.
Props wildworks, mukesh27, shailu25, maulikmakwana2008, huzaifaalmesbah, sabernhardt, khushi1501, ozgursar, noruzzaman, gaisma22, sirlouen, joedolson.
Fixes#64856.
Built from https://develop.svn.wordpress.org/trunk@62106
git-svn-id: http://core.svn.wordpress.org/trunk@61388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Populate the uploading progress bar visual naming element. Provides a nominal accessibility improvement, in that long uploads can be found and recognized during the upload process. Fix an alignment issue in the bulk select button. Follow up to [61757].
Props siliconforks, presskopp, ozgursar, joedolson.
Fixes#64883.
Built from https://develop.svn.wordpress.org/trunk@62104
git-svn-id: http://core.svn.wordpress.org/trunk@61386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Since [61438], all CSS files for the block library are being copied twice into two separate locations: `wp-includes/blocks/BLOCKNAME/` (the previous location) and `wp-includes/css/dist/block-library/BLOCKNAME/`.
Since the copies added to the `css/dist` directory are not actually being used and moving the files was the original intention in [61438], this adds an exclusion rule to the `grunt copy:gutenberg-styles` task to allow the `tools/gutenberg/copy.js` script to handle these files.
Props jorbin, youknowriad.
See #64933.
Built from https://develop.svn.wordpress.org/trunk@62103
git-svn-id: http://core.svn.wordpress.org/trunk@61385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This broke while porting over the relevant logic from the `wp-ai-client` package to Core.
With this changeset, the lifecycle hooks `wp_ai_client_before_generate_result` and `wp_ai_client_after_generate_result` fire as expected.
Props shadyvb, gziolo.
Fixes#64935.
Built from https://develop.svn.wordpress.org/trunk@62101
git-svn-id: http://core.svn.wordpress.org/trunk@61383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
#62075 introduced the WP_ALLOW_COLLABORATION constant to help hosts disable RTC at the platform level. The constant was defined in wp_functionality_constants(), which runs in wp-settings.php after collaboration.php is loaded. That created a boot-order edge case where wp_is_collaboration_enabled() could be called before the constant existed – for instance via SHORTINIT.
This commit moves the constant definition into a new wp_is_collaboration_allowed() function in collaboration.php. The function checks the constant, and if it's missing, defines it on the spot from the environment variable (defaulting to true). wp_is_collaboration_enabled() now delegates to wp_is_collaboration_allowed() for the constant check, and the admin UI calls wp_is_collaboration_allowed() directly to decide whether to show the checkbox or a "disabled" notice. It also slightly improves the label of the "enable RTC" checkbox on the settings page.
Props peterwilsoncc, mcsf, joen, ingeniumed.
Developed in https://github.com/WordPress/wordpress-develop/pull/11333.
See #64904.
Built from https://develop.svn.wordpress.org/trunk@62100
git-svn-id: http://core.svn.wordpress.org/trunk@61382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Replaces add_post_meta/update_post_meta with wpdb->insert/wpdb->update.
This prevents a real-time editing session from invalidating WP_Query and various other post caches every few seconds. RTC stores awareness and sync information in post meta with high frequency. However, every call the *_post_meta functions invalidated post caches.
This commit avoids this frequent invalidation by removing the direct *_post_meta calls in favor of $wpdb calls.
Props czarate, mukesh27, paulkevan.
Developed in https://github.com/WordPress/wordpress-develop/pull/11325.
See #64696.
Built from https://develop.svn.wordpress.org/trunk@62099
git-svn-id: http://core.svn.wordpress.org/trunk@61381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset fixes some missing implementations of the new Admin UI in buttons and help links located on the "Edit Image" screen and within the related modal.
Props huzaifaalmesbah, hmbashar, audrasjb, mukesh27, wildworks, noruzzaman, shailu25, manhar, amin7, amesplant.
Fixes#64759.
See #64308.
Built from https://develop.svn.wordpress.org/trunk@62098
git-svn-id: http://core.svn.wordpress.org/trunk@61380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
With the new admin design, there were some issues with floating elements in the custom links section of the classic Menu screen. This changeset simplifies the CSS implementation by removing floats and `wp-clearfix` classes from some elements in favor of a more robust implementation based on flex positionning.
Props audrasjb, huzaifaalmesbah, shailu25, nikunj8866, joedolson, khushi1501, ozgursar.
Fixes#64692.
See #64308.
Built from https://develop.svn.wordpress.org/trunk@62097
git-svn-id: http://core.svn.wordpress.org/trunk@61379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This change allows HTTP redirect URLs for loopback addresses (`127.0.0.1`, `[::1]`) in `wp_is_authorize_application_redirect_url_valid()`, regardless of environment type. This aligns the application password implementation with RFC 8252 7.3.
It's worth noting that section 8.3 of the RFC recommends against allowing `localhost` as a loopback redirect, since it may be susceptible to firewall interception and DNS resolution poisoning.
Props aquarius, pento.
Fixes#57809.
Built from https://develop.svn.wordpress.org/trunk@62096
git-svn-id: http://core.svn.wordpress.org/trunk@61378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Since PHP 8.1, the `auto_detect_line_endings` setting is deprecated:
> The `auto_detect_line_endings` ini setting modifies the behavior of `file()` and `fgets()` to support an isolated `\r` (as opposed to `\n` or `\r\n`) as a newline character. These newlines were used by “Classic” Mac OS, a system which has been discontinued in 2001, nearly two decades ago. Interoperability with such systems is no longer relevant.
Reference: [https://wiki.php.net/rfc/deprecations_php_8_1#auto_detect_line_endings_ini_setting PHP RFC: Deprecations for PHP 8.1: auto_detect_line_endings ini setting].
> The `auto_detect_line_endings` ini setting has been deprecated. If necessary, handle `\r` line breaks manually instead.
Reference: [1cf4fb739f/UPGRADING (L456-L457) PHP 8.1 Upgrade Notes].
This commits adds code to replace the deprecated setting and still handle old-style `\r` line-terminated files in `PO::read_line()` using `strpos()` + `fseek()`. Includes a unit test covering `\r`, `\n`, and `\r\n` line endings.
Follow-up to [51633], [51636].
Props akirk, apermo, westonruter, SergeyBiryukov.
Fixes#64928.
Built from https://develop.svn.wordpress.org/trunk@62093
git-svn-id: http://core.svn.wordpress.org/trunk@61375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
